mpl: seed standard cells when all macros are fixed - #11276
Open
oharboe wants to merge 1 commit into
Open
Conversation
When every macro is fixed, HierRTLMP::run() skipped the whole pipeline, including generateTemporaryStdCellsPlacement() and the soft blockages around macros. A full run seeds every standard cell at the center of its cluster before global placement reads the database, so a macro placement re-injected through place_macro/MACRO_PLACEMENT_TCL diverged from the run that generated it (~2% achieved period on designs where this was measured) even with bit-identical macro geometry. Now a design with standard cells goes through clustering, shaping and the soft-macro annealing even when there are no unfixed macros: the fixed macros act as fixed obstacles (as they already did in mixed fixed/unfixed designs), no macro is moved, standard cells are seeded at their cluster centers and the soft blockages are created, matching what a generating run leaves behind. Macro-only designs with no standard cells skip as before. The new all_fixed_macros1 test locks every macro and checks that the standard cells come out placed, no macro moved and the blockages exist. The no_unfixed_macros golden gains the design-data report block that is now printed before the skip; its DEF is unchanged. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the macro placer to ensure that designs with standard cells but no unfixed macros still go through the clustering process. This allows the temporary standard-cell placement and soft blockages to be generated consistently, which is useful when re-injecting placements. A new integration test all_fixed_macros1 has been added to verify this behavior. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When every macro is fixed, HierRTLMP::run() skipped the whole pipeline,
including generateTemporaryStdCellsPlacement() and the soft blockages
around macros. A full run seeds every standard cell at the center of its
cluster before global placement reads the database, so a macro placement
re-injected through place_macro/MACRO_PLACEMENT_TCL diverged from the run
that generated it (~2% achieved period measured on a macro-array design)
even with bit-identical macro geometry.
With this PR a design with standard cells goes through clustering,
shaping and the soft-macro annealing even when there are no unfixed
macros: fixed macros act as fixed obstacles (as they already did in mixed
fixed/unfixed designs), no macro is moved, standard cells are seeded at
their cluster centers and the soft blockages are created — matching what
a generating run leaves behind. Macro-only designs with no standard cells
skip as before.
Test: all_fixed_macros1 locks every macro and checks the standard cells
come out placed, no macro moved, and the blockages exist. The
no_unfixed_macros golden gains the design-data report block now printed
before the skip; its DEF is unchanged.
🤖 Generated with Claude Code