Skip to content

linear_programming: raise on simplex non-convergence - #14607

Merged
cclauss merged 1 commit into
TheAlgorithms:masterfrom
Kcstring:fix-simplex-maxiter-error
Sep 10, 2026
Merged

linear_programming: raise on simplex non-convergence#14607
cclauss merged 1 commit into
TheAlgorithms:masterfrom
Kcstring:fix-simplex-maxiter-error

Conversation

@Kcstring

@Kcstring Kcstring commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Describe your change:

Fixes #14584
Fixes #15047
Fixes #15243

Tableau.run_simplex() now raises a descriptive ValueError when Tableau.maxiter is exhausted instead of silently returning {}. This lets callers distinguish a non-converged or cycling tableau from a real empty solution.

The doctest temporarily sets Tableau.maxiter = 0 to cover the non-convergence path deterministically.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Testing:

  • python3 -m pytest linear_programming/simplex.py
  • python3 -m ruff check linear_programming/simplex.py

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 29, 2026

@priya-sundaram-dev priya-sundaram-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct fix for #14584: replaces the silent return {} with an informative ValueError on non-convergence, and the doctest is nicely self-verifying (sets maxiter=0, asserts the raise, restores it) with no new files. My recommended pick for this bug (triage in #15081). Thanks @Kcstring!

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 10, 2026
@cclauss
cclauss merged commit 6d18fee into TheAlgorithms:master Sep 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: run_simplex() returns empty dict {} on max iteration instead of raising an informative error

4 participants