Raise ValueError for invalid A1Z26 input#14974
Open
bengokaysaglam wants to merge 1 commit into
Open
Conversation
algorithms-keeper
Bot
added
enhancement
bengokaysaglam
force-pushed
the
fix/a1z26-input-validation
branch
from
July 26, 2026 09:31
1efafc3 to
1c2704e
Compare
Author
|
Hi! I noticed that the remaining failing Ruff check is caused by unrelated files, as ciphers/a1z26.py is no longer reported. The doctests for my changes pass locally, and the pre-commit checks are now successful. Please let me know if there's anything else I should update. Thanks! |
AI Code Review (PR Review Agent)
|
mindaugl
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Summary
This PR adds input validation to the A1Z26 encoder.
Changes:
ValueErrorfor empty input.a-z.All doctests pass successfully.