Skip to content

Raise ValueError for negative inputs in radix_sort#14975

Open
keerthitn9 wants to merge 1 commit into
TheAlgorithms:masterfrom
keerthitn9:fix/radix-sort-negative-input
Open

Raise ValueError for negative inputs in radix_sort#14975
keerthitn9 wants to merge 1 commit into
TheAlgorithms:masterfrom
keerthitn9:fix/radix-sort-negative-input

Conversation

@keerthitn9

Copy link
Copy Markdown

Fixes #14950

radix_sort() previously returned an incorrect result when given
negative integers instead of raising an error. This adds an input
check that raises ValueError for negative values, plus a doctest
example covering the new behavior.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes sorts/radix_sort.py: radix_sort() does not raise exception for negative inputs #14950".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorts/radix_sort.py: radix_sort() does not raise exception for negative inputs

1 participant