Skip to content

fix(sorts): raise TypeError when bucket_count is not an integer in bucket_sort (#14970) - #14985

Closed
TheRodzz wants to merge 2 commits into
TheAlgorithms:masterfrom
TheRodzz:fix-bucket-sort-float-count
Closed

fix(sorts): raise TypeError when bucket_count is not an integer in bucket_sort (#14970)#14985
TheRodzz wants to merge 2 commits into
TheAlgorithms:masterfrom
TheRodzz:fix-bucket-sort-float-count

Conversation

@TheRodzz

Copy link
Copy Markdown

Closes #14970

Summary

Adds type validation to bucket_sort() to raise a TypeError when bucket_count is passed as a float (or non-integer) value, preventing internal TypeError exceptions when attempting to range over floats.

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@TheRodzz, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bucket_sort has no dedicated error handling when the number of buckets in inputted as a float instead of an integer.

2 participants