Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
- Coverage 95.89% 95.88% -0.01%
==========================================
Files 396 396
Lines 30440 30431 -9
==========================================
- Hits 29191 29180 -11
- Misses 1249 1251 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Should I disable |
Watagon
marked this pull request as ready for review
September 16, 2026 04:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors
kth_factorto use Rust iterator methods instead of allocating and manually searching aVec<i32>.The implementation iterates over the candidate factors, keeps the values that divide
nevenly, selects the(k - 1)th matching value, and returns-1when no such factor exists. The existing behavior and test cases are preserved.I would appreciate the maintainers' guidance on two API questions:
k == 0? The current implementation assumes a one-based factor index, andk == 0currently causes an unsigned subtraction underflow in debug builds.i32with-1indicating that the kth factor does not exist, as in common implementations of this problem, or should it be changed to the more idiomatic Rust typeOption<i32>?Type of change
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.CONTRIBUTING.mdand my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]that or try to optimize your code or make the test easier to run. We have this rule because we have hundreds of tests to run; If each one of them took 300ms, we would have to wait for a long time.The clippy warnings
I'm getting the runaround.
The new rule
clippy::rest-pattern-accessible-fieldis causing problems.An error before the fix:
After fix it following the help: