Skip to content

fix(ui5-dynamic-page): toggle button reading fixed - #13990

Merged
PetyaMarkovaBogdanova merged 13 commits into
mainfrom
fix-dp-reading
Sep 11, 2026
Merged

fix(ui5-dynamic-page): toggle button reading fixed#13990
PetyaMarkovaBogdanova merged 13 commits into
mainfrom
fix-dp-reading

Conversation

@PetyaMarkovaBogdanova

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

fix(ui5-dynamic-page): add tooltip to header action buttons for correct screen reader reading

The expand/collapse and pin toggle buttons lacked a tooltip property,
causing screen readers to skip or misread them. Adding tooltip matching
the existing accessibleName ensures assistive technologies announce the
button's purpose consistently.

Additionally, the sticky positioning of the header actions wrapper is now
driven by a CSS custom property (--_ui5_dp_header_actions_top) instead
of a fully-inlined style string. This keeps position: sticky always
active in CSS and only the top value is overridden via the custom
property, avoiding a class-vs-inline specificity conflict.

Fixes #13924

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@PetyaMarkovaBogdanova
PetyaMarkovaBogdanova marked this pull request as ready for review September 11, 2026 06:03
@PetyaMarkovaBogdanova
PetyaMarkovaBogdanova merged commit 1aba7b4 into main Sep 11, 2026
14 checks passed
@PetyaMarkovaBogdanova
PetyaMarkovaBogdanova deleted the fix-dp-reading branch September 11, 2026 14:37
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-13990--ui5-webcomponents.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ui5-dynamic-page]: Click pin header button JAWS/NVDA will read out "Header Expanded banner landmark"

2 participants