fix(ui5-shellbar): update Joule assistant button icon in website samples - #14038
Open
kgogov wants to merge 2 commits into
Open
fix(ui5-shellbar): update Joule assistant button icon in website samples#14038kgogov wants to merge 2 commits into
kgogov wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://pr-14038--ui5-webcomponents-preview.netlify.app |
The Joule toggle button in the assistant slot was missing the correct icon swap behavior. When toggled on, the button should display the filled Joule icon (da-2); when toggled off, it should show the outlined icon (da). Updated all affected website samples (HTML + React variants): - Import da-2 icon alongside da - Add click handler that swaps icon between da and da-2 on toggle - Add unique IDs to toggle buttons in multi-instance samples Fixes #14021
kgogov
force-pushed
the
fix/joule-samples
branch
from
September 11, 2026 07:46
0c51305 to
43b2bb8
Compare
PetyaMarkovaBogdanova
self-requested a review
September 11, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Joule toggle button in the assistant slot was missing the correct icon swap behavior. When toggled on, the button should display the filled Joule icon (da-2); when toggled off, it should show the outlined icon (da).
Updated all affected website samples (HTML + React variants):
Fixes #14021