fix(ui5-list): restore keyboard and body selection for InactiveSelectable items - #14045
Open
dobrinyonkov wants to merge 1 commit into
Open
fix(ui5-list): restore keyboard and body selection for InactiveSelectable items#14045dobrinyonkov wants to merge 1 commit into
dobrinyonkov wants to merge 1 commit into
Conversation
…able items Downport of #14037 to 2.25.1. InactiveSelectable items could not be selected via Space/Enter or item-body click because fireItemPress early-returned for the type, and the checkbox/radio are tabindex="-1" (keyboard-unreachable). Restore the press path and suppress only the public item-click event for InactiveSelectable in List.onItemPress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downport of #14037 to 2.25.1.
Problem
InactiveSelectableitems could not be selected via Space, Enter, or item-body click —fireItemPressearly-returned for the type, and the checkbox/radio aretabindex="-1"(keyboard-unreachable). Only a direct mouse click on the checkbox/radio worked.Fix
ListItem.ts—fireItemPressno longer early-returns forInactiveSelectable.List.ts—onItemPresssuppresses only the publicitem-clickevent forInactiveSelectable, while still selecting.@since 2.25.1preserved).Tests
List.cy.tsxupdated to the corrected contract — 147/147 passing. Manual page added attest/pages/ListInactiveSelectable.html.Clean cherry-pick of
b02452d3abeontorelease-2.25.1(no conflicts;@since 2.25.1unchanged).