Fix TypeError from HEALPix grid.node_lat when not yet populated - #1664
Open
Sevans711 wants to merge 1 commit into
Open
Fix TypeError from HEALPix grid.node_lat when not yet populated#1664Sevans711 wants to merge 1 commit into
grid.node_lat when not yet populated#1664Sevans711 wants to merge 1 commit into
Conversation
(also adds regression test. See #1637)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1637
Overview
Grid.node_latwas failing on any HEALPix grid whennode_latwas not already been populated. For example,ux.Grid.from_healpix(zoom=2).node_latwas causing TypeError.The fix here is exactly the one proposed in that issue:
Adds a regression test which would have failed before but now succeeds.
PR Checklist
General
Testing & Benchmarking
AI Disclosure
AI Usage: just GitHub Copilot inline code suggestions.