fix(auth): avoid repeated passwordless table checks - #1710
Conversation
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe passwordless authentication manager no longer performs lazy table installation during initialization. Authentication tables use their standard versioned upgrade hooks. Tests verify the removed method and the ChangesPasswordless authentication table upgrades
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
admin_initupgrade hooks already registered throughTable_LoaderVerification
vendor/bin/phpunit --filter Passwordless_Auth_Test(8 tests, 44 assertions)vendor/bin/phpcs inc/auth/class-passwordless-auth-manager.php tests/WP_Ultimo/Auth/Passwordless_Auth_Test.phpvendor/bin/phpstan analyse inc/auth/class-passwordless-auth-manager.php tests/WP_Ultimo/Auth/Passwordless_Auth_Test.php --no-progress.githooks/pre-commitaidevops.sh v3.32.247 plugin for OpenCode v1.18.9 with gpt-5.6-sol spent 8m and 165,549 tokens on this with the user in an interactive session.
Summary by CodeRabbit
Bug Fixes
Tests