CI: bump Wrench to 3.11.5 and expand PR Unity version coverage - #701
Open
lopezt-unity wants to merge 2 commits into
Open
CI: bump Wrench to 3.11.5 and expand PR Unity version coverage#701lopezt-unity wants to merge 2 commits into
lopezt-unity wants to merge 2 commits into
Conversation
Regenerate .yamato via the CI cookbook to pick up the new recipe output (split editor/playmode UTR suites, updated wrench-localapv URL, console-failure filtering step).
Drop the MaximumEditorVersion cap in ProBuilderSettings so Wrench's default editor range is used instead of being capped at 6000.5, which now yields 6000.0/6000.3/6000.6/6000.7/trunk. Also remove the temporary exclusion of 6000.6 from the PR trigger (added in #682 as a workaround for a failing VM) so all validated versions gate the PR trigger.
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The Wrench upgrade and regenerated CI configuration consistently expand the validation matrix through trunk, keep all pull-request dependencies resolvable, and add bounded crash-report uploads for the affected runners. I examined the source recipes, generated job references and matrices, regeneration metadata, and the generated upload scripts.
Reviewed commit be1ea65
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 38.43% 38.55% +0.12%
==========================================
Files 279 279
Lines 39164 39195 +31
==========================================
+ Hits 15052 15112 +60
+ Misses 24112 24083 -29
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecipeEngine.Modules.Wrench) 2.12.0 -> 3.11.5 and regenerate.yamato/**MaximumEditorVersioncap inProBuilderSettingsso PRs are now validated against 6000.0, 6000.3, 6000.6, 6000.7, and trunk6000.6exclusion from the PR trigger (added in Fixes for 6.1 publication #682 as a workaround for a failing VM), so all validated versions gate PRsTest plan
dotnet buildof.Tools/CI/ProBuilder.Cookbook.csprojsucceeds against Wrench 3.11.5