Conversation
CyMule
marked this pull request as ready for review
July 21, 2026 01:35
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Shadow auto-approve: would auto-approve. Optimizes MIME detection to avoid a full-body BytesIO copy by proxying the spooled upload, preserving behavior and filename. Includes regression tests verifying the original stream is used and rewound. A bounded, performance-improving refactor with no observable external change.
Re-trigger cubic
…ection # Conflicts: # CHANGELOG.md # prepline_general/api/__version__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect unknown upload MIME types through a proxy of the existing upload stream, avoiding a full-file BytesIO copy. Preserve the uploaded filename as a detection hint and rewind the original stream in a finally block, including when detection fails.
Compatibility
No new file-size, format, or processing limit is introduced. Explicit MIME hints and unsupported-type handling are unchanged. The proxy keeps the request-owned stream open; upload lifecycle management remains with FastAPI. Detection results match the prior copied-stream path on tested text, HTML, CSV, JSON, PDF, XLSX, and PPTX inputs, with both memory-backed and disk-backed spools.
Validation
Synced with current main on September 14, 2026.