Fix setter decorator for project property - #8362
Merged
Merged
Conversation
`PluginCommandContext.project`'s setter is decorated with `@function.setter` instead of `@project.setter`. Because `@x.setter` returns a new property built from `x`, this attaches the new setter to the *function* property while keeping its original getter, and binds the whole thing to the name `project`. The result: `context.project` reads back `self._function` instead of `self._project`.
There was a problem hiding this comment.
Pull request overview
This PR corrects the PluginCommandContext.project property setter decorator so that assignments to context.project update and subsequently read back self._project (rather than accidentally binding to the function property and reading self._function).
Changes:
- Fix
PluginCommandContext.projectsetter to use@project.setterinstead of@function.setter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginCommandContext.project's setter is decorated with@function.setterinstead of@project.setter. Because@x.setterreturns a new property built fromx, this attaches the new setter to the function property while keeping its original getter, and binds the whole thing to the nameproject. The result:context.projectreads backself._functioninstead ofself._project.