Find split mode snapshots - #14
Merged
Merged
Conversation
UseUniqueDirectory in split mode names the directory `{prefix}.received`
and the files inside it after their targets, so no file name carries a
`.received.` marker. The scan globs `**/*.received.*`, so it matched none
of them and the tool reported nothing pending for a project using split
mode. There was no way to accept such a snapshot.
Verify records the pair for every received file it leaves on disk, split
mode included, so the maps already knew about these. They were only ever
consulted as a lookup for files the glob had already found, never
enumerated. Pairs the glob did not find are now added directly.
Only pairs the glob missed are added, so nothing is reported twice, and
the inline staging filter is applied to them as well, so a staged inline
snapshot the glob deliberately skipped is not reintroduced by its map.
A map records absolute paths and a test can send its snapshots anywhere,
so a map found under the scanned root can name a file outside it. The
existing code could never surface one, since it only looked maps up by
files already found under the root. Pairs outside the root are dropped,
so reviewing a directory still cannot reach out of it.
Without a map a split mode snapshot stays invisible: the name carries
nothing to pair on, and inventing a pairing is worse than reporting
nothing. Pinned by a test.
Headers name the directory for a split mode snapshot. The file is named
after its target, commonly `target.txt`, so the file name alone does not
say which test is under review and every split mode snapshot in a run
read the same. Flat snapshots are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UseUniqueDirectory in split mode names the directory
{prefix}.receivedand the files inside it after their targets, so no file name carries a.received.marker. The scan globs**/*.received.*, so it matched none of them and the tool reported nothing pending for a project using split mode. There was no way to accept such a snapshot.Verify records the pair for every received file it leaves on disk, split mode included, so the maps already knew about these. They were only ever consulted as a lookup for files the glob had already found, never enumerated. Pairs the glob did not find are now added directly.
Only pairs the glob missed are added, so nothing is reported twice, and the inline staging filter is applied to them as well, so a staged inline snapshot the glob deliberately skipped is not reintroduced by its map.
A map records absolute paths and a test can send its snapshots anywhere, so a map found under the scanned root can name a file outside it. The existing code could never surface one, since it only looked maps up by files already found under the root. Pairs outside the root are dropped, so reviewing a directory still cannot reach out of it.
Without a map a split mode snapshot stays invisible: the name carries nothing to pair on, and inventing a pairing is worse than reporting nothing. Pinned by a test.
Headers name the directory for a split mode snapshot. The file is named after its target, commonly
target.txt, so the file name alone does not say which test is under review and every split mode snapshot in a run read the same. Flat snapshots are unchanged.