fix(vtable-sheet): exclude test shim from compile - #5296
Merged
fangsmile merged 1 commit intoAug 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #5295
💡 Background and solution
vtable-sheet's production TypeScript project currently includessrc/test-shims/vtable-plugins.ts. That test-only shim re-exports the siblingvtable-pluginssource tree, which is outsidevtable-sheet's configuredrootDir, sorushx compilefails with TS6059/TS6307 diagnostics.This change:
MultiSheetImportResultfrom the existing public@visactor/vtable-pluginsexport instead of its source path.The Jest configuration continues to resolve the shim for package tests.
📝 Changelog
vtable-sheetproduction compile.vtable-sheet生产编译包含仅测试使用的插件源码。☑️ Self-Check before Merge
Testing
node ../../common/scripts/install-run-rushx.js compileinpackages/vtable-sheetnode ../../common/scripts/install-run-rushx.js testinpackages/vtable-sheet(76 suites, 446 tests)rush test --only tag:packagerush build -t @visactor/vtable-sheet(completed with the repository's existing warning-tolerant build configuration)