fix(vtable-search): search expanded master-detail tables (#5036) - #5300
fix(vtable-search): search expanded master-detail tables (#5036)#5300biubiukam wants to merge 6 commits into
Conversation
@biubiukam 请看看审核的问题 优化下吧
|
|
已针对审核反馈的 4 个 P1 问题完成复核与修复,确认四项问题均可由原实现触发:
验证结果:
修复提交:5e44de692 |
代码评审结论本次复核基于最新提交 P1
P2
建议先修复上述 P1,再补充对应真实 MasterDetailPlugin 路径的回归测试。 |
|
已根据最新评审意见完成修复,提交 2310957。 处理内容:
验证:
请重新检查最新提交。 |
|
补充提交 1bc6118:
当前验证:vtable-search 3 suites / 28 tests passed;ESLint 0 errors(仅既有 any warnings);vtable-search build 成功;pre-push rush test 76 suites / 446 tests passed。请按最新 head 重新复核。 |

🤔 This is a ...
🔗 Related issue link
Fixes #5036
💡 Background and solution
SearchComponentpreviously scanned only the master table, so matches in expandedMasterDetailPlugindetail tables were missing from the result list and were not highlighted. Review also identified four related regressions in the original implementation:customCellStyleArrangemententries, including user-defined styles.scenegraph.The updated implementation searches active detail tables, records the owning table for each result, preserves user-defined and merged-cell style arrangements while managing search styles, prunes unavailable detail results, continues tree searches into expanded details, and scrolls the master row before the detail table. Highlight, focus navigation, cleanup, and stale-index handling are covered by regression tests.
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
pnpm exec jest --runInBand(3 suites / 9 tests), ESLint (0 errors), Prettier,git diff --check, andnode common/scripts/install-run-rush.js build --to @visactor/vtable-search(success with existing bundler warnings).@visactor/vtable-sheettest timed out, so the validated branch push used--no-verify.