chore(ci): drop the gates the fleet already runs and fold the e2e nightly into nightly.yml - #259
Merged
Merged
Conversation
Contributor
File size check0 over a hard cap (fails), 14 warning(s).
Split the file, wrap the line, shorten or exempt the comment, or list the path in 5 managed file(s) skipped; repo-platform owns them. |
Vivswan
added
the
repo-platform:sync
github-actions
Bot
removed
the
repo-platform:sync
Contributor
|
Build Sync report
Written
Mirrors
ReviewHold for review: no |
There was a problem hiding this comment.
🟢 Approval recommended
The workflow consolidation is internally consistent and its reporting conditions are covered by focused tests.
Pull request overview
Consolidates CI by relying on fleet-provided gates and moving full-corpus e2e coverage into the existing nightly workflow.
Changes:
- Removes duplicate knip and YAML lint CI setup.
- Adds e2e execution and failure reporting to
nightly.yml. - Removes the standalone e2e workflow and label.
File summaries
| File | Description |
|---|---|
.github/actions/setup/action.yml |
Removes yamllint installation support. |
.github/settings.local.yml |
Removes the retired e2e label. |
.github/workflows/checks.yml |
Drops duplicate knip and YAML lint steps. |
.github/workflows/e2e-nightly.yml |
Deletes the superseded workflow. |
.github/workflows/nightly-fuzz.yml |
Updates references to the consolidated nightly. |
.github/workflows/nightly.yml |
Adds e2e and integrates its result into reporting. |
CONTRIBUTING.md |
Documents the new nightly arrangement. |
package.json |
Aligns the local check script with repo-owned checks. |
test/docs/nightly-workflows.test.ts |
Tests consolidated report conditions and labels. |
test/docs/repo-owned-workflows.test.ts |
Removes obsolete YAML lint behavior tests. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vivswan
force-pushed
the
chore/fleet-audit-dedupe-gates
branch
from
September 18, 2026 06:46
17c22d1 to
1ec2575
Compare
Vivswan
added
the
repo-platform:sync
github-actions
Bot
removed
the
repo-platform:sync
…htly into nightly.yml The managed ci.yml's standard-checks job runs the fleet knip and yamllint actions against the same knip.json and the managed .yamllint on every PR, so the knip and lint:yaml steps in checks.yml judged the same tree twice, at a second knip version and behind a second yamllint pin in the setup composite. Both steps go, with the yamllint input of the composite and the CI-fails-when-missing branch of lint:yaml; the check script mirrors checks.yml again. e2e-nightly.yml duplicated the shape of the nightly starter. Its corpus run and endpoint-coverage tripwire are now the e2e job of nightly.yml, in the report job's needs and folded into its red and green conditions, so a red corpus files the nightly-failure issue and the e2e-fuzz label is gone. The test of the report job evaluates the conditions with each sibling's result substituted, so a sibling left out of either side fails the suite.
Vivswan
force-pushed
the
chore/fleet-audit-dedupe-gates
branch
from
September 18, 2026 06:49
8746519 to
38a42ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
How
yamllintinput and pin. Thecheckscript mirrors checks.yml again.e2ejob (fresh spec fetch, corpus, endpoint-coverage tripwire, failure artifacts) in the report job'sneedsand both conditions.e2e-nightly.ymland itse2e-fuzzlabel go..github/settings.ymlwithout the label and moves the manifest stamp to the platform head; nothing there is hand-edited..husky/shell besidelefthook.ymlwas untracked cruft and is removed on this machine only.Proof
bun run checkgreen, 3322 tests.||turned into&&, fails it (both controls run red).e2e-nightly,e2e-fuzz,lint:yaml-in-CI, and theyamllint:input have zero references left in the tree.Technical details
nightly-failurereport (run link) instead of a fuzz-issue excerpt of report.md; the e2e job still uploadstest/e2e/.artifacts/on failure.!= 'success'shape does fold skipped into red).knipscript stay for local runs, as the platform repository keeps its own.