Skip to content

Continuing user initiated navigation on page-script-initiated reload #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgorszkowski-igalia merged 1 commit into from
Sep 9, 2026
+18 −1
Merged

Continuing user initiated navigation on page-script-initiated reload #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Source/WebCore/loader/FrameLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,7 +1405,24 @@ void FrameLoader::loadURL(FrameLoadRequest&& frameLoadRequest, const String& ref

bool sameURL = shouldTreatURLAsSameAsCurrent(&frameLoadRequest.requesterSecurityOrigin(), newURL);
const String& httpMethod = request.httpMethod();


static bool keepNavigationOnLocationReload = false;
static bool keepNavigationOnLocationReloadInitialized = false;
if (!keepNavigationOnLocationReloadInitialized) {
keepNavigationOnLocationReload = !!getenv("WPE_KEEP_NAVIGATION_ON_LOCATION_RELOAD");
keepNavigationOnLocationReloadInitialized = true;
}
// A page-script-initiated reload (e.g. window.location.reload() via a timer) racing
// an already-in-flight client/user navigation to a different URL (e.g. a native
// webkit_web_view_load_uri() call). Stop a page-script-initiated reload here.
if (keepNavigationOnLocationReload && isReload(newLoadType) && !frameLoadRequest.isRequestFromClientOrUserInput()) {
DocumentLoader* ongoingLoader = m_policyDocumentLoader ? m_policyDocumentLoader.get() : m_provisionalDocumentLoader.get();
if (ongoingLoader && ongoingLoader->isRequestFromClientOrUserInput() && ongoingLoader->request().url() != newURL) {
FRAMELOADER_RELEASE_LOG(ResourceLoading, "loadURL: navigation to: %s will be continued after location reload to url: %s", ongoingLoader->request().url().string().utf8().data(), newURL.string().utf8().data());
return;
}
}

// Make sure to do scroll to fragment processing even if the URL is
// exactly the same so pages with '#' links and DHTML side effects
// work properly.
Expand Down