Skip to content

revert: drop the settlement-version quote gate from this train (#23) - #24

Merged
jacderida merged 1 commit into
mainfrom
revert/pr-23-settlement-version
Aug 18, 2026
Merged

revert: drop the settlement-version quote gate from this train (#23)#24
jacderida merged 1 commit into
mainfrom
revert/pr-23-settlement-version

Conversation

@jacderida

Copy link
Copy Markdown
Member

Reverts the merge of #23, holding the settlement-version change off the
2026-08-18 release train. It re-lands with its coordinated set.

Why

#23's own body carries a "Release readiness: coordinated set, do not merge alone" section:

This crate is inert by itself... But merging publishes it, and publication is what unblocks the other two, so it should not land until the coordinated set is fleet-ready.
Approved on the code, not a statement that the change set is production ready.

The coordinated set it names — ant-node #204 and ant-client #171 — are both still OPEN with
changes requested. That leaves this train shipping the wire vocabulary while the enforcement and
adversarial evidence for a T3 change set, and its ADR, exist only on unmerged branches.

Blast radius: none

By #23's own analysis the change is inert on the wire — the new variants are never constructed
unless a client sends them and a node acts on them, and both are separate PRs. The revert restores
main to exactly the released v2.3.2 tree:

$ git diff --stat e2a7cc5 HEAD    # e2a7cc5 = the v2.3.2 promote merge
(empty)

ant-protocol therefore stays at 2.3.2 and drops off this train entirely.

Re-landing

Land as a set once #204 and #171 are ready. One thing to fix first: ADR-0010 is now taken on
ant-node by ADR-0010-beta-upgrade-channel-semantics.md (landed with ant-node #208), so the
settlement ADR needs renumbering.

Worth considering a mechanism that actually holds a PR like this — draft state, a blocking label,
or a Linear blocks relation — since a release-readiness condition written in the PR body does not
stop a merge.

🤖 Generated with Claude Code

Reverts the merge of #23. The change is held off the 2026-08-18 release
train and will land with its coordinated set.

#23's own body states "Release readiness: coordinated set, do not merge
alone" and that it "should not land until the coordinated set is fleet
ready", naming ant-node #204 and ant-client #171 as carrying the open
gates. Both are still open with changes requested, so the enforcement
and adversarial evidence for this T3 change set — and its ADR — exist
only on unmerged branches.

Nothing here changes behaviour on its own: the new variants are never
constructed unless a client sends them and a node acts on them, both of
which are separate PRs. This revert is therefore inert on the wire, and
restores ant-protocol to exactly the released v2.3.2 tree.

Re-land as a set once #204 and #171 are ready. Note that ADR-0010 is now
taken on ant-node by the beta upgrade channel ADR, so the settlement
ADR needs renumbering before #204 lands.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jacderida
jacderida merged commit 2bd604a into main Aug 18, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant