Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules/mft/netexec_mft.ymlfails to load because three keys underfilter:are indented inconsistently, so they are not siblings ofnetexec:.chainsaw lintonmaster(82fabe2):In a hunt it degrades gracefully rather than failing the run, which is likely why it went unnoticed:
The rule has been in this state since it was added in #226 (merged 2026-04-01).
Fix
Re-indents
netexec1,netexec2andnetexec3to 2 spaces so all four blocks referenced byconditionare siblings. Three lines changed; no detection logic, patterns or metadata touched.Verification
Parsed structure now matches what
condition: netexec or netexec1 or netexec2 or netexec3expects — all four resolve to mappings with aFullPathlist (1, 2, 1 and 10 patterns respectively), and there are no stray keys left underfilter.Also re-ran a parse sweep over all 127 rule files: this was the only one that failed, and it now passes.