Skip to content

Administration: Guard network admin bootstrap on single sites - #12933

Open
ArkaPrabhaChowdhury wants to merge 3 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-38076-network-admin-guard
Open

Administration: Guard network admin bootstrap on single sites#12933
ArkaPrabhaChowdhury wants to merge 3 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-38076-network-admin-guard

Conversation

@ArkaPrabhaChowdhury

@ArkaPrabhaChowdhury ArkaPrabhaChowdhury commented Aug 7, 2026

Copy link
Copy Markdown

Load the network administration bootstrap only after confirming that the request is running on a multisite installation.

Trac ticket: https://core.trac.wordpress.org/ticket/38076

Description

On single-site installations, wp-admin/network/admin.php previously loaded wp-admin/admin.php before the multisite guard ran. This allowed plugin-generated network-admin pages to be dispatched before the request was rejected.

This change:

  • Moves the WordPress bootstrap before the network-admin dispatch path.
  • Rejects network-admin requests on single-site installations before plugin-page dispatch.
  • Adds regression coverage for the single-site bootstrap path.

Testing

  • php -l src/wp-admin/network/admin.php
  • php -l tests/phpunit/tests/admin/wpNetworkAdmin.php
  • php vendor/bin/phpcbf --standard=phpcs.xml.dist src/wp-admin/network/admin.php tests/phpunit/tests/admin/wpNetworkAdmin.php
  • php vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-admin/network/admin.php tests/phpunit/tests/admin/wpNetworkAdmin.php
  • PHPUnit could not be run locally because the test database was unavailable.
  • The PR's CI follow-up addressed the shared DB_NAME already defined bootstrap failure; the current CI status should be reviewed separately.

Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5
Used for: Reviewing the Trac ticket and current source, identifying the initial implementation and regression-test approach, assisting with the initial draft of the PR description, and helping diagnose the PHPUnit bootstrap failure. The final implementation, test changes, validation commands, and submitted description were reviewed and accepted by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ArkaPrabhaChowdhury
ArkaPrabhaChowdhury marked this pull request as ready for review August 10, 2026 08:33
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props arkaprabhachowdhury.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant