Administration: Guard network admin bootstrap on single sites - #12933
Administration: Guard network admin bootstrap on single sites#12933ArkaPrabhaChowdhury wants to merge 3 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Load the network administration bootstrap only after confirming that the request is running on a multisite installation.
Trac ticket: https://core.trac.wordpress.org/ticket/38076
Description
On single-site installations,
wp-admin/network/admin.phppreviously loadedwp-admin/admin.phpbefore the multisite guard ran. This allowed plugin-generated network-admin pages to be dispatched before the request was rejected.This change:
Testing
php -l src/wp-admin/network/admin.phpphp -l tests/phpunit/tests/admin/wpNetworkAdmin.phpphp vendor/bin/phpcbf --standard=phpcs.xml.dist src/wp-admin/network/admin.php tests/phpunit/tests/admin/wpNetworkAdmin.phpphp vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-admin/network/admin.php tests/phpunit/tests/admin/wpNetworkAdmin.phpDB_NAME already definedbootstrap failure; the current CI status should be reviewed separately.Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5
Used for: Reviewing the Trac ticket and current source, identifying the initial implementation and regression-test approach, assisting with the initial draft of the PR description, and helping diagnose the PHPUnit bootstrap failure. The final implementation, test changes, validation commands, and submitted description were reviewed and accepted by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.