Skip to content

Formatting: match CSS function names case-insensitively in safecss_fi… - #12949

Open
Anupkankale wants to merge 1 commit into
WordPress:trunkfrom
Anupkankale:fix/65838-safecss-case-insensitive-functions
Open

Formatting: match CSS function names case-insensitively in safecss_fi…#12949
Anupkankale wants to merge 1 commit into
WordPress:trunkfrom
Anupkankale:fix/65838-safecss-case-insensitive-functions

Conversation

@Anupkankale

Copy link
Copy Markdown

CSS function names are ASCII case-insensitive, so CALC(1px + 2px), URL(foo.jpg), and LINEAR-GRADIENT(red, blue) are all valid CSS. Every function-matching pattern in safecss_filter_attr() was case-sensitive, however, so valid declarations using anything other than all-lowercase function names were silently dropped.

Add the i modifier to the url(), gradient, and generic function patterns, and lowercase the value before the url( / -gradient( sniffing done for custom properties.

Only the function names are matched loosely; the grammar each pattern accepts is unchanged, so a mixed-case value is now held to exactly the same standard as its lowercase equivalent. Protocol checking in wp_kses_bad_protocol() was already case-insensitive, so URL() values are validated the same way url() values are.

Property names remain case-sensitive, which is a separate concern.

Fixes #65838. See #64974.

Trac ticket:

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…lter_attr().

CSS function names are ASCII case-insensitive, so `CALC(1px + 2px)`,
`URL(foo.jpg)`, and `LINEAR-GRADIENT(red, blue)` are all valid CSS.
Every function-matching pattern in `safecss_filter_attr()` was
case-sensitive, however, so valid declarations using anything other than
all-lowercase function names were silently dropped.

Add the `i` modifier to the `url()`, gradient, and generic function
patterns, and lowercase the value before the `url(` / `-gradient(`
sniffing done for custom properties.

Only the function names are matched loosely; the grammar each pattern
accepts is unchanged, so a mixed-case value is now held to exactly the
same standard as its lowercase equivalent. Protocol checking in
`wp_kses_bad_protocol()` was already case-insensitive, so `URL()` values
are validated the same way `url()` values are.

Property names remain case-sensitive, which is a separate concern.

Fixes #65838. See #64974.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @your-github-email@gmail.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@irozum irozum left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix — CSS function names genuinely are ASCII case-insensitive, so silently dropping CALC(...)/URL(...)/LINEAR-GRADIENT(...) while accepting the lowercase equivalents was a real (if minor) sanitizer bug, and this closes the gap without loosening the actual grammar each pattern accepts.

I checked out the branch and ran the affected suite (--filter Tests_Kses, 451 tests/1525 assertions, all green, including the new mixed-case data provider cases), plus composer lint:errors and phpstan on kses.php — both clean.

I traced the security-relevant path by hand: wp_kses_bad_protocol_once2() already lowercases the scheme before comparing against $allowed_protocols (kses.php:2057), so URL(JavaScript:...) is rejected exactly like url(javascript:...) — confirmed by the new test cases. And since only the function names get the /i modifier while each pattern's grammar is untouched, an unrecognized/malformed mixed-case function (e.g. EXPRESSION(...)) still leaves its ( in the test string and gets caught by the trailing [\\(&=}] check. Good call leaving property-name case-sensitivity (Text-transform) out of scope — that's a separate, more debatable question.

One small thing unrelated to the code: the PR body has "Fixes #65838" in prose but the template's "Trac ticket:" line is still empty, which is why the props bot flagged a missing Trac link — worth filling in the full https://core.trac.wordpress.org/ticket/65838 URL there so the linkage is picked up automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants