#13655 fix: stripslash passwords on login and user edit - #12953
Draft
skikken wants to merge 2 commits into
Draft
Conversation
Passwords containing quotes or backslashes were hashed with magic quote slashes intact on the login, admin user edit, and password reset paths, so the stored hash did not match the actual password. Unslash passwords at the input boundary and migrate legacy hashes on authentication by checking the slashed variant and rehashing. Closes #13655
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state on trunk: wp_insert_user() already stripslashes user_pass before hashing (the data compaction unslashes the whole user record at the end of the function), so new hashes are of the unslashed password. The remaining gaps are the input paths that pass the slashed value around:
Trac ticket: https://core.trac.wordpress.org/ticket/13655
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Sonnet
Used for: Writing test cases
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.