Skip to content

HTML API: Restore supported tag list in set_modifiable_text() notice - #12957

Open
sirreal wants to merge 1 commit into
WordPress:trunkfrom
sirreal:html-api/restore-set-modifiable-text-message
Open

HTML API: Restore supported tag list in set_modifiable_text() notice#12957
sirreal wants to merge 1 commit into
WordPress:trunkfrom
sirreal:html-api/restore-set-modifiable-text-message

Conversation

@sirreal

@sirreal sirreal commented Aug 10, 2026

Copy link
Copy Markdown
Member

WP_HTML_Tag_Processor::set_modifiable_text() emits a _doing_it_wrong() notice when called on a tag that doesn't support it. r62715 replaced the message's list of supported tags with a generic "This tag does not support setting modifiable text.", removing the only hint about which tags are supported.

See #12289 (comment)

Restore the list, extended with the raw text tags that r62715 added support for:

Only the IFRAME, NOEMBED, NOFRAMES, SCRIPT, STYLE, TEXTAREA, TITLE, and XMP tags support setting modifiable text.

The generic message for non-tag tokens is unchanged.

Follow-up to r62715.

Trac ticket: https://core.trac.wordpress.org/ticket/65372

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Applying the message change and drafting this description.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

When `set_modifiable_text()` is called on a tag that doesn't support it, the
message no longer names which tags do. Restore that list, extended with the
raw text tags added in [62715], so callers have a clue about where to look.

Follow-up to [62715].

See #65372.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants