Conversation
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52447 602fd350-edb4-49c9-b593-d223f7449a82
Merges [52454] to the 5.9 branch. Props dd32, xknown, peterwilsoncc, ehtis. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52458 602fd350-edb4-49c9-b593-d223f7449a82
Merges [52455] to the 5.9 branch. Props vortfu, xknown, dd32. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52460 602fd350-edb4-49c9-b593-d223f7449a82
Merges [52456] to the 5.9 branch. Props vortfu, xknown, dd32. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52462 602fd350-edb4-49c9-b593-d223f7449a82
Merges [52457] to the 5.9 branch. Props zieladam, whyisjake, xknown, peterwilsoncc, desrosj, iandunn. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52464 602fd350-edb4-49c9-b593-d223f7449a82
This change fixes a wrong punctuation in a link description object of the menu items controller endpoint. It also updates qUnit test fixtures accordingly. Props la-geek, audrasjb, tobifjellner, hellofromtonya, davidbaumwald. Merges [52535] and [52536] to the 5.9 branch. Fixes #54745. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52541 602fd350-edb4-49c9-b593-d223f7449a82
The workshops page doesn't specifically show 5.9 content at this stage (and likely won't until much later), so it needs to be changed to learn.wordpress.org homepage. Props hlashbrooke, audrasjb, davidbaumwald. Merges [52453] to the 5.9 branch. Fixes #54755. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52542 602fd350-edb4-49c9-b593-d223f7449a82
The default preset styles of WordPress (font sizes, colors, gradients) are now provided via the global stylesheet to avoid duplication of styles. This stylesheet can be found in the front-end with the name global-styles-inline-css. The default presets are important to support old content that may use them and also patterns, that can use cross-theme styles. Props oandregal. Merges [52547] to the 5.9 branch. Fixes #54781. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52548 602fd350-edb4-49c9-b593-d223f7449a82
…format. Themes that use the same preset slugs as WordPress uses need to be updated. From the devnote https://make.wordpress.org/core/2022/01/08/updates-for-settings-styles-and-theme-json/ The CSS for some of the presets defined by WordPress (font sizes, colors, and gradients) was loaded twice for most themes in WordPress 5.8: in the block-library stylesheet plus in the global stylesheet. Additionally, there were slight differences in the CSS in both places. In WordPress 5.9 those were consolidated into a single place, the global stylesheet whose name is global-styles-inline-css that is now loaded for all themes in the front-end. For themes to override the default values they can use the theme.json and provide the same slug. Themes that do not use a theme.json can still override the default values by enqueuing some CSS that sets the corresponding CSS Custom Property. This commit does the second for the twenty twenty theme. Props oandregal. Merges [52549] to the 5.9 branch. Fixes #54782. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52550 602fd350-edb4-49c9-b593-d223f7449a82
- [Block Library - Query Pagination Next]: Hide block if custom query has no results - [WP 5.9] Fix: HTML tags like inline images in nav links break submenu layout - Check for nextpage to display page links for paginated posts - Navigation: Set the default for --navigation-layout-align to "flex-start" when using vertical orientation - [Block Library - Query Loop]: Use gap for the grid view - Update page list flex variables to match navigation. - Site logo: Fix range control on landscape logo - Restore canvas padding for classic themes - RichText: Fix dead key input on Windows - Fix: Impossible to clear colors if color palettes are removed. - Gallery block: pass any custom attributes through the gallery v2 migration script - Reduce specificity of legacy font sizes defined by core - Update: Improve escaping on the search block See #54487. Props isabel_brison. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52552 602fd350-edb4-49c9-b593-d223f7449a82
This commit syncs changes for the default theme from its active development repository to core. This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], [52375], [52392], and [52430]. It includes fixes to the theme's spacing and adds a search template. To view the full set of changes, visit WordPress/twentytwentytwo@8564fd2...f0346e1. Props richtabor, kjellr, danieldudzic, scruffian, jffng. Merges [52555] to the 5.9 branch. See #54318. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52557 602fd350-edb4-49c9-b593-d223f7449a82
…to print only when blocks render. In a block theme, additional block styles registered using the wp_enqueue_block_style function should only get printed when the block exists on a page. However, they currently always get rendered. This commit is a backport from Gutenberg that fixes the issue by printing the styles when a block renders. Follow-up to [52069]. Props poena, aristath, Mamaduka. Merges [52556] to the 5.9 branch. Fixes #54787. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52559 602fd350-edb4-49c9-b593-d223f7449a82
In `wp_enqueue_block_style` when `rtl` versions of CSS files are detected, `wp_style_add_data` is called to add the metadata to the registered sheet. However, the stylesheet `handle` argument is misspelled as `hanle`. This change corrects the argument name. Props omaeyusuke. Merges [52558] to the 5.9 branch. Fixes #54786. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52560 602fd350-edb4-49c9-b593-d223f7449a82
The home template's description should be: "Displays as the site's home page, or as the Posts page when a static home page isn't set." This commit fixes the typo changing "it" to "isn't". Follow-up to [52331]. Props kharisblank, talldanwp. Merges [52554] to the 5.9 branch. Fixes #54787. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52561 602fd350-edb4-49c9-b593-d223f7449a82
Tone down the brightness of the dashboard panel by using a white background behind the main text, and use the highlight color from each color scheme for the main background. This also introduces a $scheme-name SCSS variable to allow overrides for specific color schemes. Props critterverse, sabernhardt, joedolson, audrasjb. Merges [52562] to the 5.9 branch. Fixes #54489. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52564 602fd350-edb4-49c9-b593-d223f7449a82
Use the correct Field Guide link. Update the SVGs used on Freedoms and Privacy. Add more spacing between sections on the About page, fixed spacing between rows on Freedoms page. Props critterverse, audrasjb, versusbassz. Merges [52563] to the 5.9 branch. See #54270. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52565 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52566 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52567 602fd350-edb4-49c9-b593-d223f7449a82
This change avoids a warning thrown by a missing slash in a post thumbnail lazyload related regular expression. Follow-up to [52065]. Props SierraTR, audrasjb, costdev, flixos90. Merges [52563] to the 5.9 branch. Fixes #54815. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52579 602fd350-edb4-49c9-b593-d223f7449a82
This commit syncs minor changes for the default theme from its active development repository to core. This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], [52375], [52392], [52430], and [52555]. It includes fixes to the group, cover, and template part block padding and removes unnecessary group block wrappers from many patterns. To view the full set of changes, visit WordPress/twentytwentytwo@69d5c51...91f8748. Props kjellr, richtabor, audrasjb, jffng. Merges [52589] to the 5.9 branch. Fixes #54318. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52590 602fd350-edb4-49c9-b593-d223f7449a82
Reverting changeset due to reported issue of menu being hidden after clicking on certain mobile devices. Props dhusakovic, audrasjb, SergeyBiryukov, costdev, joedolson. Reverts [51946] on the 5.9 branch. See #54837, #53587. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52592 602fd350-edb4-49c9-b593-d223f7449a82
…ditor screens. Remote block patterns from wp.org were to be loaded through a callback hooked into the `current_screen` filter. Within 2 callbacks, i.e. `_load_remote_featured_patterns()` and `_load_remote_block_patterns()`, a guard clause bailed out early if the `$current_screen->is_block_editor` is `false`. However, the `current_screen` filter is unreliable to detect the block editor. Why? In the block and Site Editor screens, `$current_scren->is_block_editor` is not set until after the filter is executed. Whoopsie. This commit no longer uses the `current_screen` filter. Instead, it explicitly loads the remote block patterns by invoking both private functions (now not callbacks) directly in the screen files for the block and site editor screens. With this change, passing `WP_Screen` object into these functions is no longer needed. As the `_load_remote_block_patterns()` function was introduced in 5.8.0, its function parameter is now deprecated and the guard clause retained for backwards compatibility. Follow-up to [51021], [52377]. Props poena, noisysocks, peterwilsoncc, hellofromTonya, audrasjb. Merges [52593] to the 5.9 branch. Fixes #54806. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52594 602fd350-edb4-49c9-b593-d223f7449a82
Update packages to include these bug fixes from Gutenberg: - Stop keypresses being caught by other elements when they happen in a CustomSelectControl - Remove color, spacing, and layout options for Template Part block - Try: parse shortcode blocks outside the content - Fix aria-modal attribution with multiple navs on page - Gallery block: Remove warning notice about mobile version required - Fix Home template description typo - Fix enqueueing additional styles for blocks only when rendered - fix typo (hanle -> handle) - SelectControl: mark the children prop as optional - Remove warning for enqueued styles in Editor - Add context to font style and font weight related translation strings - Temporarily remove text decoration from Nav block - Fix empty secondary sidebar overlapping widget editor content on mobile viewports - Fix hiding the bottom of tablet/mobile preview in Site Editor See #54487. Props isabel_brison. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52596 602fd350-edb4-49c9-b593-d223f7449a82
Update packages to include these bug fixes from Gutenberg: Navigation Block: update micromodal to 0.4.10 to fix menu close button on mobile Props ryelle, poena, get_dave, talldanwp, aristath, kjellr, audrasjb, desrosj. Merges [52598] to the 5.9 branch. See #54487. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52599 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52600 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52601 602fd350-edb4-49c9-b593-d223f7449a82
This commit updates the required WordPress version of the 2022 default theme to 5.9 in advance of its release on January 25. Props hellofromtonya, kjellr, desrosj. Merges [52612] and [52613] to the 5.9 branch. Fixes #54318. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52614 602fd350-edb4-49c9-b593-d223f7449a82
[52549] updated some default presets in use by default themes to the new format. However, this change would cause elements to lose their styling when active on an older version of WordPress. Merges [52615] to the 5.9 branch. See #54782. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52616 602fd350-edb4-49c9-b593-d223f7449a82
These tests are failing after [52614], which raised the minimum version of WordPress required for Twenty Twenty-Two. Since the value of `$wp_version` is still less than 5.9, these are failing. After `$wp_version` is officially bumped to `5.9`, these should be removed. Props hellofromTonya, Clorith. See #54318. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52617 602fd350-edb4-49c9-b593-d223f7449a82
This bumps the versions of the default bundled themes in preparation for release with WordPress 5.9. The new versions are: - Twenty Ten: 3.6 - Twenty Eleven: 4.0 - Twenty Twelve: 3.6 - Twenty Thirteen: 3.5 - Twenty Fourteen: 3.3 - Twenty Fifteen: 3.1 - Twenty Sixteen: 2.6 - Twenty Seventeen: 2.9 - Twenty Nineteen: 2.2 - Twenty Twenty: 1.9 - Twenty Twenty-One: 1.5 Props audrasjb. Merges [52618] to the 5.9 branch Fixes #54783. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@52619 602fd350-edb4-49c9-b593-d223f7449a82
…VERSION`. This changes the default values for `LOCAL_PHP` and `LOCAL_DB_VERSION` in the 5.9 branch from `latest` to `8.1-fpm` (with beta support) and `5.7`, respectively, to properly reflect the highest versions of PHP and MySQL that this branch will support. See #61533. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@58664 602fd350-edb4-49c9-b593-d223f7449a82
This re-adds Slack notices for the E2E workflow in the 5.9 branch. These were mistakenly removed in [58358]. See #61733, #61213. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@58794 602fd350-edb4-49c9-b593-d223f7449a82
The previous domain that was used to test for a host whose IPv4 address cannot be resolved, `exampleeeee.com`, got registered and has an A-record now, so it's not invalid anymore. `.invalid` is intended for use in online construction of domain names that are sure to be invalid and which it is obvious at a glance are invalid. Reference: [https://datatracker.ietf.org/doc/html/rfc2606#section-2 Reserved Top Level DNS Names: TLDs for Testing, & Documentation Examples]. Follow-up to [52084], [58384], [58388]. Reviewed by peterwilsoncc. Merges test changes from [59293] to the 5.9 branch. Props sippis, johnbillion, MattyRob, swissspidy, SergeyBiryukov. Fixes #62303. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@59305 602fd350-edb4-49c9-b593-d223f7449a82
This makes use of the new input added in [59635] that fixes tests on `ubuntu-24` in the 5.9 branch. Props swissspidy, mukesh27. See #62808. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@59637 602fd350-edb4-49c9-b593-d223f7449a82
The Root Certificate bundle maintained by Mozilla ships in WordPress to allow SSL certificates to be verified on hosts with incomplete, outdated, or invalid local SSL configurations. This updates the `ca-bundle.crt` file to the latest version, which applies upstream changes from the bundle maintained by Mozilla and keeps all unexpired legacy 1024bit certificates which are kept for backward compatibility purposes (see [35919]). Partially merges [59740] and [59969] to the 5.9 branch. Props johnbillion, desrosj, whyisjake, ayeshrajans, SergeyBiryukov, swissspidy, skithund, barry. See #62811, #62711. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60001 602fd350-edb4-49c9-b593-d223f7449a82
This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps. Merges [60006] to the 5.9 branch. See #63117. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60011 602fd350-edb4-49c9-b593-d223f7449a82
Merges [60320] to the 5.9 branch. See #63165. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60378 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60549 602fd350-edb4-49c9-b593-d223f7449a82
The 5.9 branch is now 5.9.12-alpha. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60597 602fd350-edb4-49c9-b593-d223f7449a82
The WordPress Importer plugin now requires PHP 7.2 or higher. The plugin’s unit tests were removed as of [59769] in favor of running only within the plugin’s repository on GitHub instead. [59769] was made during the 6.8 release cycle, so all WP <= 6.7 branches still checkout the latest revision for the plugin before running the PHPUnit test suite. This change modifies the `env:install` script to download version `0.9.0` of the plugin (which is the last version of the Importer plugin that supports PHP < 7.2) when a qualifying version is being tested. Merges [60748] to the 5.9 branch. Props @swissspidy. See #63983. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60755 602fd350-edb4-49c9-b593-d223f7449a82
- REST API: Increase the specificity of capability checks for collections when the `edit` context is in use. - Menus: Prevent HTML in menu item titles from being rendered unexpectedly. Merges [60814], [60815], [60816] to the 5.9 branch. Props andraganescu, desrosj, ehti, hurayraiit, iandunn, joehoyle, johnbillion, jorbin, mnelson4, noisysocks, peterwilsoncc, phillsav, rmccue, timothyblynjacobs, vortfu, westonruter , whyisjake, zieladam. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60827 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@60849 602fd350-edb4-49c9-b593-d223f7449a82
Props jorbin, desrosj. Merges [60691], [61146] to the 5.9 branch. See #63165. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@61157 602fd350-edb4-49c9-b593-d223f7449a82
The `macos-13` runner image is deprecated with support set to be fully removed next month. This updates the build process testing workflow’s MacOS job to use the `macos-15-intel` runner in the 5.9 branch. The `-intel` part is required because older branches of WordPress use Node.js `14.x` which never supported `arm64` environments. The `macos-15-intel` image will be the last `x86_64` runner published for GitHub Actions and will be supported until August 2027. Merges [61226] to the 5.9 branch. See #64246. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@61230 602fd350-edb4-49c9-b593-d223f7449a82
This trims the unit testing matrix to the highest and lowest supported version of each major PHP branch. Props desrosj, johnbillion See #64083 git-svn-id: https://develop.svn.wordpress.org/branches/5.9@61811 602fd350-edb4-49c9-b593-d223f7449a82
- XML-RPC: Switch to `wp_safe_remote()` when fetching a pingback URL. - HTML API: Prevent `WP_HTML_Tag_Processor` instances being unserialized and add some extra logic for validating pattern and template file paths. - KSES: Optimize PCRE pattern detecting numeric character references. - Customize: Improve escaping approach used for nav menu attributes. - Media: Ensure the attachment parent is accessible to the user before showing a link to it in the media manager. - Administration: Ensure client-side templates are only detected when they're correctly associated with a script tag. - Filesystem API: Don't attempt to extract invalid files from a zip when using the PclZip library. Merges [61879-61885,61887,61890,61913] to the 5.9 branch. Props johnbillion, xknown, dmsnell, jorbin, peterwilson, desrosj, westonruter, jonsurrell, aurdasjb. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@61951 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@61961 602fd350-edb4-49c9-b593-d223f7449a82
Scope a Composer audit exception for GHSA-3pwp-g2mj-5p3v so composer install resolves on the 7.0 branch. WPCS is a dev-only dependency, and this keeps it at 3.3.0 rather than bumping it and churning the coding standards on a release branch. Trunk fix: [62874]. Developed in: #12741 Reviewed by: jorbin, lancewillett. Merges [62876] to 5.9 branch. Props johnbillion, jorbin, lancewillett. See #65739. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@62890 602fd350-edb4-49c9-b593-d223f7449a82
…anch. Tags in the `wordpress-develop` repo originate from the corresponding svn tag. This means the target commit for the tag must already exist on `wordpress-develop` and therefore its full workflow has already run, usually just minutes prior to the tag being pushed. This change eliminates this unnecessary duplicate workflow run and reduces bottlenecks experienced during releases. See #64893 git-svn-id: https://develop.svn.wordpress.org/branches/5.9@62911 602fd350-edb4-49c9-b593-d223f7449a82
Merges [62937] to the 5.9 branch. Reviewed by: johnbillion. See #65752. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@62988 602fd350-edb4-49c9-b593-d223f7449a82
Add an ignore for GHSA-hmqg-cxww-wqhq (CVE-2026-67434), under both its GitHub and Packagist advisory IDs. WordPress tooling does not use the vulnerable `Gitblame`, `Hgblame` or `Svnblame` report formats, so the pinned version poses no practical risk. Merges [63037] to the 5.9 branch. Props johnbillion, joedolson, jonsurrell, sergeybiryukov. Fixes #65822. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@63049 602fd350-edb4-49c9-b593-d223f7449a82
- Users: Ensure a proper email address is used before sending email confirmations. - Formatting: Prevent stack overflow in `safecss_filter_attr`. - Multisite: Enforce the active signup policy for existing users. - HTTP API: Improve compliance with IPv4 Special-Purpose Address Space. - Users: Prevent Usernames from mangling HTML - Canonical: Only redirect for publicly viewable post types. - Administration: When `wp_is_large_user_count()`, ensure that the post author is always added to author dropdown. - Editor: Fix output for post date. Merges [63060],[63061],[63062],[63063],[63064],[63065],[63067] to the 5.9 branch. Props xknown, westonruter, jeremyfelt, peterwilsoncc, paulkevan, lucasbustamante, jorbin, desrosj, vortfu, dmsnell, johnbillion, ehtis, batmoo, lancewillett, jonsurrell, isabel_brison, bernhard-reiter, tyxla, aduth. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@63103 602fd350-edb4-49c9-b593-d223f7449a82
Props aduth, joedolson, jorbin, desrosj, johnbillion. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@63121 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@63123 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/branches/5.9@63154 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the things I think should be placed in the core of WordPress is to display the size of various photos and files that are uploaded to the host through WordPress in the media library menu (as a column in the table to make comparison easier). After a while and by adding different files, we do not know which file gets the most size from the host and in general it is very good that the webmaster can easily view the size of different files to make site management easier because according to the experience, This Menu is one of the most sensitive WordPress menus and must be carefully monitored. You can add this feature using the code below ;
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.