Skip to content

[43390]: get_super_admins() should not return "admin" by default #8915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soean wants to merge 5 commits into
base: trunk
Choose a base branch
from
+4 −3
Open

[43390]: get_super_admins() should not return "admin" by default #8915

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
982da95
get_super_admins() should not return "admin" by default
Soean Jun 5, 2025
bb3b536
Update trunk
Soean Aug 10, 2026
a06bcaf
Update trunk
Soean Aug 10, 2026
cd87447
Fix: Update default site_admins to an empty array instead of containi…
Soean Aug 10, 2026
2a2ac43
Add @since comment
Soean Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/wp-includes/capabilities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@ function remove_role( $role ) {
* Retrieves a list of super admins.
*
* @since 3.0.0
* @since 7.2.0 The `site_admins` site option no longer defaults to `array( 'admin' )`.
*
* @global array $super_admins
*
Expand All @@ -1163,7 +1164,7 @@ function remove_role( $role ) {
function get_super_admins() {
global $super_admins;

return $super_admins ?? get_site_option( 'site_admins', array( 'admin' ) );
return $super_admins ?? get_site_option( 'site_admins', array() );
}

/**
Expand Down Expand Up @@ -1224,7 +1225,7 @@ function grant_super_admin( $user_id ) {
do_action( 'grant_super_admin', $user_id );

// Directly fetch site_admins instead of using get_super_admins().
$super_admins = get_site_option( 'site_admins', array( 'admin' ) );
$super_admins = get_site_option( 'site_admins', array() );

$user = get_userdata( $user_id );
if ( $user && ! in_array( $user->user_login, $super_admins, true ) ) {
Expand Down Expand Up @@ -1272,7 +1273,7 @@ function revoke_super_admin( $user_id ) {
do_action( 'revoke_super_admin', $user_id );

// Directly fetch site_admins instead of using get_super_admins().
$super_admins = get_site_option( 'site_admins', array( 'admin' ) );
$super_admins = get_site_option( 'site_admins', array() );

$user = get_userdata( $user_id );
if ( $user ) {
Expand Down
Loading