You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ask the workflow-dispatch API to return the exact codegen run it created
wait for that run ID instead of selecting the repository's latest run after a fixed sleep
remove the unused checkout and broad write permissions
pin the GitHub App token action and replace the extra third-party wait action with GitHub CLI
cancel superseded validation for the same pull request and bound total runtime
Why
Concurrent pull requests can currently select each other's codegen runs, which can report the wrong validation result. GitHub's dispatch API now returns the created run ID when return_run_details is enabled.
Validation
actionlint .github/workflows/pr-validation.yml
git diff --check
The private codegen repository and its application credentials are intentionally not accessible to this contribution. Maintainers should confirm one real dispatch in the trusted upstream environment before taking this pull request out of draft.
Current status across #833–#837 appears cross-correlated: all five public PR Validation jobs selected the same private xero-internal/xeroapi-sdk-codegen run, 31792288728, which failed at Build SDK. I cannot access that private job log or approve the pending fork workflows. Because validation runs from the upstream pull_request_target workflow, this PR cannot bootstrap its own correlation fix. Could a maintainer please inspect private run 31792288728, approve the PR Linting and OpenAPI Spec Diff runs, apply or merge this correlation fix to master, and then rerun #833–#837 after the base fix (preferably serially)? I have not changed or retriggered the five branches because the public evidence does not tie the shared downstream failure to their individual diffs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Concurrent pull requests can currently select each other's codegen runs, which can report the wrong validation result. GitHub's dispatch API now returns the created run ID when
return_run_detailsis enabled.Validation
actionlint .github/workflows/pr-validation.ymlgit diff --checkThe private codegen repository and its application credentials are intentionally not accessible to this contribution. Maintainers should confirm one real dispatch in the trusted upstream environment before taking this pull request out of draft.