Skip to content

[Feat] 활동 일지 탭 청년 공고 영역 Hidden 처리 - #95

Merged
choijungp merged 2 commits into
developfrom
fix/hiddenNotice
Aug 21, 2026
Merged

[Feat] 활동 일지 탭 청년 공고 영역 Hidden 처리#95
choijungp merged 2 commits into
developfrom
fix/hiddenNotice

Conversation

@choijungp

@choijungp choijungp commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🌁 Background

청년 공고 API가 해결되지 않아 해당 영역을 숨겨야 합니다 !!

📱 Screenshot

ScreenRecording_08-21-2026.22-23-01_1.MP4

👩‍💻 Contents

  • 청년 공고 관련 코드 주석 처리 (추후 API 문제 해결 후 주석 삭제)
  • 탭바 아이콘 관련 불필요한 이미지 파일 삭제

Summary by CodeRabbit

  • 개선 사항
    • 활동 일지 화면에서 내비게이션 바를 숨기고, 감정 캘린더가 배지 영역 바로 아래에 표시되도록 레이아웃을 조정했습니다.
    • 활동 일지 탭 아이콘이 원본 색상으로 표시되도록 개선했습니다.
  • 버그 수정
    • 사용되지 않는 빈 리포트 아이콘 리소스를 정리했습니다.

@choijungp choijungp self-assigned this Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 18c77206-c030-455a-acb2-7a889be3209b

📥 Commits

Reviewing files that changed from the base of the PR and between f78eb11 and dc94f04.

⛔ Files ignored due to path filters (18)
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/home_fill_icon.imageset/navigation=home, status=fill.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/home_fill_icon.imageset/navigation=home, status=fill@2x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/home_fill_icon.imageset/navigation=home, status=fill@3x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/mypage_fill_icon.imageset/navigation=_mypage, status=fill.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/mypage_fill_icon.imageset/navigation=_mypage, status=fill@2x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/mypage_fill_icon.imageset/navigation=_mypage, status=fill@3x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/recommend_fill_icon.imageset/navigation=recommend, status=fill.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/recommend_fill_icon.imageset/navigation=recommend, status=fill@2x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/recommend_fill_icon.imageset/navigation=recommend, status=fill@3x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/navigation=report, status=empty.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/navigation=report, status=empty@2x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/navigation=report, status=empty@3x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/report_empty_icon.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/report_empty_icon@2x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/report_empty_icon@3x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_fill_icon.imageset/navigation=report, status=fill.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_fill_icon.imageset/navigation=report, status=fill@2x.png is excluded by !**/*.png
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_fill_icon.imageset/navigation=report, status=fill@3x.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/Contents.json
  • Projects/Presentation/Sources/ActivityHistory/View/ActivityHistoryViewController.swift
  • Projects/Presentation/Sources/Common/View/TabBarView.swift
💤 Files with no reviewable changes (1)
  • Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/Contents.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

활동 기록 화면에서 청년 공고 영역을 숨기고 감정 캘린더 위치를 조정했습니다. 네비게이션 바를 숨겼습니다. 활동 일지 탭 아이콘은 원본 색상으로 표시하며 관련 에셋 메타데이터를 삭제했습니다.

Changes

활동 기록 UI 조정

Layer / File(s) Summary
활동 기록 화면 레이아웃 변경
Projects/Presentation/Sources/ActivityHistory/View/ActivityHistoryViewController.swift
화면 표시 시 네비게이션 바를 숨깁니다. 청년 공고 뷰와 관련 스택 뷰 및 제약 조건을 비활성화합니다. 감정 캘린더를 배지 영역 아래에 배치합니다.
활동 일지 탭 아이콘 렌더링
Projects/Presentation/Sources/Common/View/TabBarView.swift, Projects/Presentation/Resources/Images.xcassets/TabBarIcon/report_empty_icon.imageset/Contents.json
활동 일지 탭 아이콘에 .alwaysOriginal 렌더링 모드를 적용합니다. report_empty_icon 에셋의 Contents.json을 삭제합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dc94f

This PR makes a localized UI visibility change and removes unused tab bar image assets. No actionable merge-blocking risk remains beyond normal checks and review.

Poem

깡충 rabbit, 화면을 살펴보니
공고 영역은 살짝 숨고
달력은 배지 곁에 자리했네.
아이콘은 제 빛을 되찾고
에셋 꼬리표는 사라졌네.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 활동 일지 탭의 청년 공고 영역을 숨기는 주요 변경 사항을 명확하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hiddenNotice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@choijungp
choijungp merged commit 7bf91e0 into develop Aug 21, 2026
2 checks passed
@choijungp
choijungp deleted the fix/hiddenNotice branch August 21, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant