fix: Playwright build verison conflict - #104
Merged
Merged
Conversation
Previously `npx playwright install` used whichever `playwright` binary landed in `.bin/`, installing browsers only for that one version. If a project has multiple versions installed (e.g. `@playwright/test` and `@web/test-runner-playwright` resolving different releases), the test runner would fail with "Executable doesn't exist" because its required browser cache path was never populated. Now we `find` every `playwright/cli.js` in node_modules and run `node <cli> install --with-deps` for each, so all versions get their binaries regardless of hoisting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
PR Checks Complete✅ Analysis✅ Formatting✅ Testing |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Yarn/dependencies and adjusts the GitHub Action’s Playwright setup step to avoid version conflicts by installing browser binaries for multiple Playwright versions found in node_modules.
Changes:
- Update Yarn (4.17.0 → 4.18.0) and refresh dependency lockfile, including
@actions/githubmajor bump. - Add
resolutionsto pin/override versions oftar,fast-xml-parser, andundici. - Update the Playwright install step to scan
node_modulesfor Playwright CLIs and run installs per discovered version.
Reviewed changes
Copilot reviewed 4 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Lockfile refresh reflecting updated deps and Yarn resolution changes. |
package.json |
Adds resolutions, bumps deps/devDeps, updates packageManager to Yarn 4.18.0. |
.yarnrc.yml |
Points Yarn to the 4.18.0 release bundle. |
src/scripts/testing.ts |
Changes Playwright install behavior to support multiple installed Playwright versions. |
dist/licenses.txt |
Updates bundled dependency license list after dependency changes. |
custom-elements.json |
Regenerated custom elements manifest reflecting updated dependency graph/output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
aygurs
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desp: Update yarn deps