Skip to content

fix: Playwright build verison conflict - #104

Merged
thelukewalton merged 10 commits into
mainfrom
deps
Aug 3, 2026
Merged

fix: Playwright build verison conflict#104
thelukewalton merged 10 commits into
mainfrom
deps

Conversation

@thelukewalton

Copy link
Copy Markdown
Contributor

desp: Update yarn deps

thelukewalton and others added 2 commits August 3, 2026 13:10
Previously `npx playwright install` used whichever `playwright` binary
landed in `.bin/`, installing browsers only for that one version. If
a project has multiple versions installed (e.g. `@playwright/test` and
`@web/test-runner-playwright` resolving different releases), the test
runner would fail with "Executable doesn't exist" because its required
browser cache path was never populated.

Now we `find` every `playwright/cli.js` in node_modules and run
`node <cli> install --with-deps` for each, so all versions get their
binaries regardless of hoisting.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@thelukewalton
thelukewalton requested a review from Copilot August 3, 2026 12:31
@DE7924

DE7924 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR Checks Complete

✅ Analysis

✅ Formatting

✅ Testing

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Yarn/dependencies and adjusts the GitHub Action’s Playwright setup step to avoid version conflicts by installing browser binaries for multiple Playwright versions found in node_modules.

Changes:

  • Update Yarn (4.17.0 → 4.18.0) and refresh dependency lockfile, including @actions/github major bump.
  • Add resolutions to pin/override versions of tar, fast-xml-parser, and undici.
  • Update the Playwright install step to scan node_modules for Playwright CLIs and run installs per discovered version.

Reviewed changes

Copilot reviewed 4 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Lockfile refresh reflecting updated deps and Yarn resolution changes.
package.json Adds resolutions, bumps deps/devDeps, updates packageManager to Yarn 4.18.0.
.yarnrc.yml Points Yarn to the 4.18.0 release bundle.
src/scripts/testing.ts Changes Playwright install behavior to support multiple installed Playwright versions.
dist/licenses.txt Updates bundled dependency license list after dependency changes.
custom-elements.json Regenerated custom elements manifest reflecting updated dependency graph/output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/scripts/testing.ts
Comment thread src/scripts/testing.ts
@thelukewalton
thelukewalton merged commit a9ead66 into main Aug 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants