Patches some stuff for Ashet development - #1003
Draft
ikskuh wants to merge 1 commit into
Draft
Conversation
Grazfather
reviewed
Aug 3, 2026
Grazfather
left a comment
Grazfather
left a comment
Collaborator
There was a problem hiding this comment.
Not actually a review, just a Q about this part
| diags.* = Diagnostics.init(token.index, "out of instructions", .{}); | ||
| return error.Overflow; | ||
| } | ||
|
|
||
| const result, const ov = @addWithOverflow(instr_index.?, 1); | ||
| instr_index = if (ov != 0) null else result; |
Collaborator
There was a problem hiding this comment.
Can't we just return an error here instead of using an optional type and adding these checks? or maybe at the check once at the top of the loop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some fixes and changes i've made for Ashet. This PR is just so i don't forget pushing them, and we can merge them eventually