Conversation
mattnite
force-pushed
the
cortex-m-fixes
branch
from
September 16, 2026 11:19
5a7dfc4 to
070b672
Compare
Contributor
|
Please verify all the definitions by reading through the references. To what extent did you test the rest of the code? |
tact1m4n3
force-pushed
the
cortex-m-fixes
branch
from
September 16, 2026 17:14
070b672 to
5ed0d55
Compare
tact1m4n3
force-pushed
the
cortex-m-fixes
branch
from
September 16, 2026 17:18
5ed0d55 to
50d0892
Compare
Collaborator
Author
|
Hey! Sorry, I should've checked the register definitions. If even this an LLM can't get right... 😄 I pushed the revised registers. The interrupt function changes I tested in my flight controller firmware where I use interrupts to schedule tasks. There was quite an annoying bug a while ago because of the rwm in the interrupt pend functions where some tasks wouldn't get scheduled because the interrupt wouldn't get reliably pended. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oroperation doing a rmw which was unnecessary and not atomic