fix: correct interval bounds and support mutable dispatch captures - #244
Conversation
- Use magnitude-ordered FastTwoSum to avoid spurious non-finite errors in interval addition and subtraction near f64::MAX. - Allow dimension-dispatch macro bodies to mutate captures while preserving support for consuming closures. - Skip redundant GCD work when clearing rational denominators. - Clarify numerical certificates, error provenance, and mutation guarantees in API documentation. - Sort README API entries and document the existing Gram benchmark suite.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (34)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe changes refine floating-point residuals and interval bounds, expand exact arithmetic and dispatch contract tests, strengthen executable examples, and update numerical documentation, benchmarks, and validation guidance. ChangesNumerical contracts and validation
API and exact arithmetic
Examples and project support
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change improves extreme interval arithmetic, mutable dispatch captures, rational-operation efficiency, and validation coverage without any identified current-head merge blocker. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 98.04% 98.02% -0.03%
==========================================
Files 13 13
Lines 6694 6726 +32
==========================================
+ Hits 6563 6593 +30
- Misses 131 133 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Summary by CodeRabbit
Documentation
Bug Fixes
Tests