Filter PRs by user in isFirstPullRequest

[michen00]

Summary

Two changes, both needed for first-contribution detection to be correct:

1. isFirstPullRequest() now filters by author. pulls.list has no creator parameter and nothing filtered afterward, so the check returned true only when the incoming PR was the lowest-numbered PR in the repo's entire history — any prior PR by anyone disqualified a genuine first-time contributor.

2. The first-contribution check now covers any contribution type. The action greets only when this is both the sender's first issue and their first pull request:

   if (!((await isFirstIssue(octokit)) && (await isFirstPullRequest(octokit))))
     return core.info('Skipping...Not First Contribution')

   first-interaction reads as any contribution — someone who has already opened an issue is familiar enough with the repo that a first-PR greeting is noise.

Why this fixes #369

On main the check is !isFirstIssue && !isFirstPullRequest. In a repo with issues disabled, GET /repos/{owner}/{repo}/issues returns 200 and serves pull requests only, so after the pull_request === undefined filter isFirstIssue is unconditionally true. That short-circuits the &&, and the action greets every PR author forever.

Under the combined check a vacuously-true isFirstIssue simply falls through to the pull request check, which now filters by author.

Note for reviewers

This is a change of behaviour, not a restoration. The pre-#311 implementation branched on event type, and its isFirstPull filtered by author under the comment // No way to filter pulls by creator; #311 dropped both. Restoring the branching alone fixes the over-greeting but leaves the author filter missing, which turns over-greeting into never-greeting. The any-contribution reading here is a deliberate choice, adopted from review on this PR.

Test plan

• Author filter — "Ignores pull requests from other users"
• Cross-type case — "Skips a PR message if the sender has only prior issues"
• 19 tests pass, 100% coverage
• Lint and format pass
• Bundle rebuilt

Fixes #369.

[michen00]

Hi, just checking in on this PR—happy to make any changes or provide more context if helpful.

[michen00]

Related: #410

[michen00]

@ncalteen Hiya, just checking in on this PR—happy to make any changes or provide more context if helpful.

[LapNik]

Checking typed contributions is a valid use case, but so is checking untyped contributions, I think. Maybe an issue comment should not be created if a user is familiar enough with the repository to have authored a PR.

In my opinion the name of the action first-interaction implies any contribution. The action could have subdirectories like actions/first-interaction/first-pr and actions/first-interaction/first-issue for checking specific types.

Suggested change

	// Check if this is the user's first contribution of the relevant type.
	if (isIssue && !(await isFirstIssue(octokit)))
	return core.info('Skipping...Not First Issue')
	if (isPullRequest && !(await isFirstPullRequest(octokit)))
	return core.info('Skipping...Not First Pull Request')
	// Check if this is the user's first contribution.
	if (!(await isFirstIssue(octokit) && await isFirstPullRequest(octokit)))
	return core.info('Skipping...Not First Contribution')

Though, maybe clearer function names would be something like userHasAuthoredPullRequestsPreviously and userHasReportedIssuesPreviously.

[michen00]

Adopted in eae58ce — agreed, and the naming argument is the deciding one. first-interaction should mean any contribution.

The committed line differs from your suggestion by two pairs of parentheses:

if (!((await isFirstIssue(octokit)) && (await isFirstPullRequest(octokit))))
  return core.info('Skipping...Not First Contribution')

That is prettier's doing rather than a change of intent — npm run lint rejects the suggestion as written:

src/main.ts
  41:9  error  Replace `await·isFirstIssue(octokit)·&&·await·isFirstPullRequest(octokit` with `(await·isFirstIssue(octokit))·&&·(await·isFirstPullRequest(octokit)`  prettier/prettier

and running npx prettier src/main.ts over your version emits the line above verbatim. await already binds tighter than &&, so the parentheses are cosmetic — same expression, same precedence.

The earlier commit in this PR, e73de6f, is still needed underneath it. On main, isFirstPullRequest never filters by author:

return (
  // Filter out any PRs that are newer than the current one.
  pulls.filter((pull) => pull.number < github.context.issue.number)
    .length === 0
)

pulls.list is called with only owner, repo and state — there is no creator parameter for pulls — and nothing filters afterward, so this returns true only when the incoming PR is the lowest-numbered PR in the repo. That's the isFirstPullRequest(octokit) half of your condition, so it had to be fixed for the combined check to mean anything.

eae58ce also adds the test the change is really about, which nothing covered before:

✓ Skips a PR message if the sender has only prior issues

One thing worth a maintainer's eye: this is a change of behaviour, not a restoration. Before #311 the action branched on event type —

if (isIssue) {
  firstContribution = await isFirstIssue(client, …);
} else {
  firstContribution = await isFirstPull(client, …);
}

— and that isFirstPull did filter by author, under the comment // No way to filter pulls by creator. So #311 dropped the branching and the author filter together, and #410 proposes restoring the branching. I've gone with your reading because the name supports it, but it is a new semantic rather than a revert.

On naming: agreed the current ones are ambiguous, though the rename inverts polarity at every call site — probably its own PR.

[Copilot]

🟢 Approval recommended

The changes align with the PR description and tests were updated to validate the corrected first-contribution behavior.

Pull request overview

This pull request fixes first-contribution detection for the first-interaction action by (1) making the “first PR” check specific to the PR author and (2) changing the greeting behavior to require the sender to have no prior issues and no prior pull requests.

Changes:

• Update run() to greet only when both isFirstIssue() and isFirstPullRequest() are true.
• Update isFirstPullRequest() to ignore pull requests created by other users.
• Update/add tests to cover author filtering and cross-type (“prior issues”) cases; rebuild dist/.

File summaries

File	Description
src/main.ts	Adjusts first-contribution gating logic and filters PR history by sender login.
dist/index.js	Rebuilt bundled output reflecting the updated logic.
tests/main.test.ts	Expands coverage for author-filtering and any-contribution semantics.

Review details

• Files reviewed: 2/4 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.