Skip to content

fix(training-agent): resolve sync_governance accounts across open-mode session partitions - #7100

Open
aleksUIX wants to merge 1 commit into
adcontextprotocol:mainfrom
aleksUIX:fix/7080-sync-governance-session-partition
Open

fix(training-agent): resolve sync_governance accounts across open-mode session partitions#7100
aleksUIX wants to merge 1 commit into
adcontextprotocol:mainfrom
aleksUIX:fix/7080-sync-governance-session-partition

Conversation

@aleksUIX

Copy link
Copy Markdown
Contributor

Fixes #7080.

sales_dooh never calls sync_accounts. Controller seeding writes the sandbox account into the open:default partition (seed_account keys off empty args). sync_governance then keys off accounts[0].account.brand.domain (open:acmeoutdoor.example) and looks only at that map, so local macOS open-mode runs get ACCOUNT_NOT_FOUND. Training-mode CI hides the split because both sides collapse to training:${userId}:${moduleId}.

This matches the existing accountMapsForPrincipal scan used by getAccountNotificationSubscribers and resolveAccountIdForRef. No protocol or schema change.

Test plan

  • npx vitest run --config server/vitest.config.ts tests/unit/account-handlers.test.ts (41 passed)
  • Regression: open-mode sync_governance after seed_account into a different session partition returns status: "synced"

…e session partitions

Controller seeding writes into open:default while sync_governance keys off
the nested account brand domain. Scan every principal-owned account map so
sales_dooh can register governance without a prior sync_accounts call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sales_dooh sync_governance fails ACCOUNT_NOT_FOUND on local macOS runs (green in CI)

1 participant