feat: box layout and resize + anchor observer primitives - #10558
Open
nwidynski wants to merge 3 commits into
Open
feat: box layout and resize + anchor observer primitives#10558nwidynski wants to merge 3 commits into
nwidynski wants to merge 3 commits into
Conversation
Contributor
Author
|
@LFDanLu This is the PR to look at for floating-ui, although it also addresses various other issues, like the ones coming from |
7 tasks
reidbarber
reviewed
Sep 3, 2026
| * Similar to `element.getBoundingClientRect()`, but intersected with all ancestors. | ||
| */ | ||
| public get visibleRect(): DOMRect { | ||
| throw new Error('Not implemented yet.'); |
Contributor
Author
There was a problem hiding this comment.
Kinda. I don't have a great use case for it yet, besides window scrolling in virtualizer, so it just satisfies the type for now. IIRC it wasn't added in virtualizer because walking the tree would be too costly.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes no issues directly, because this PR is intentionally limited to additions only. Migrating call sites to the new utilities and signatures is to be done in chore follow-ups, because it would otherwise be rather hard to review what changed here.
Disclaimer: This PR is tightly related to #10556! Unfortunately Github doesn't allow for Stacks to be built across forks, so we have to do with this :/
From a high-level, this PR fixes various issues with layout precision and lays the groundwork for an alternative to floating-ui. The primary file to look at is
layout.ts, which features a short description.Will close #7142, #10036, #10131, #9318 and more.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: