Skip to content

chore: (DNM) test branch for support for interactive widgets in overlay placement - #10584

Open
LFDanLu wants to merge 57 commits into
mainfrom
test_10102
Open

LFDanLu wants to merge 57 commits into
mainfrom
test_10102

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Sep 8, 2026

Copy link
Copy Markdown
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Sep 8, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 8, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 14, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 14, 2026

Copy link
Copy Markdown
## API Changes

react-aria-components

/react-aria-components:ModalRenderProps

 ModalRenderProps {
   isEntering: boolean
   isExiting: boolean
+  isOpen: boolean
   state: OverlayTriggerState
 }

/react-aria-components:PopoverRenderProps

 PopoverRenderProps {
   isEntering: boolean
   isExiting: boolean
+  isOpen: boolean
   placement: PlacementAxis | null
   trigger: string | null
 }

@react-aria/utils

/@react-aria/utils:runAfterTransition

 runAfterTransition {
-  fn: () => void
+  fn: QueuedCallback
   returnVal: undefined
 }

/@react-aria/utils:isCtrlKeyPressed

 isCtrlKeyPressed {
-  e: Event
+  event: KeyPressEvent
   returnVal: undefined
 }

/@react-aria/utils:willOpenKeyboard

 willOpenKeyboard {
-  target: Element
+  target: Element | null
   returnVal: undefined
 }

/@react-aria/utils:isKeyboardOpen

+isKeyboardOpen {
+  returnVal: undefined
+}

/@react-aria/utils:supportsKeyboard

+supportsKeyboard {
+  returnVal: undefined
+}

@rspbot

rspbot commented Sep 14, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (13)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/7161d93cd02d2c4a6f0e4d96d153f2823f98b2cf/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/7161d93cd02d2c4a6f0e4d96d153f2823f98b2cf/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants