Skip to content

chore: update workflow icon package and S2 TableView column menu - #10586

Open
yihuiliao wants to merge 5 commits into
mainfrom
update-workflow-icon
Open

chore: update workflow icon package and S2 TableView column menu#10586
yihuiliao wants to merge 5 commits into
mainfrom
update-workflow-icon

Conversation

@yihuiliao

@yihuiliao yihuiliao commented Sep 8, 2026

Copy link
Copy Markdown
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

📝 Test Instructions:

check storybook with custom column menus. double check figma's to make sure it matches design

https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1307

🧢 Your Project:

@rspbot

rspbot commented Sep 8, 2026

Copy link
Copy Markdown

Comment thread packages/@react-spectrum/s2/src/TableView.tsx Outdated
value: {
default: 'gray-700',
isHovered: 'gray-800',
isFocusVisible: 'gray-800'

@yihuiliao yihuiliao Sep 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no design for when it is focused so i just assume it's the same as hovered, we can clarify with design tho

@rspbot

rspbot commented Sep 9, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 9, 2026

Copy link
Copy Markdown
## API Changes

@react-spectrum/s2

/@react-spectrum/s2:Menu

 Menu <T> {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   autoFocus?: boolean | FocusStrategy
   children: ReactNode | (T) => ReactNode
   defaultSelectedKeys?: 'all' | Iterable<Key>
   dependencies?: ReadonlyArray<any>
   disabledKeys?: Iterable<Key>
   disallowEmptySelection?: boolean
   escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
   hideLinkOutIcon?: boolean
   id?: string
   items?: Iterable<T>
-  loadingState?: LoadingState
   onAction?: (Key, T) => void
   onClose?: () => void
-  onLoadMore?: () => any
   onSelectionChange?: (Selection) => void
   selectedKeys?: 'all' | Iterable<Key>
   selectionMode?: SelectionMode
   shouldCloseOnSelect?: boolean
   size?: 'S' | 'M' | 'L' | 'XL' = 'M'
   slot?: string | null
   styles?: StylesProp
 }

/@react-spectrum/s2:MenuProps

 MenuProps <T> {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   autoFocus?: boolean | FocusStrategy
   children: ReactNode | (T) => ReactNode
   defaultSelectedKeys?: 'all' | Iterable<Key>
   dependencies?: ReadonlyArray<any>
   disabledKeys?: Iterable<Key>
   disallowEmptySelection?: boolean
   escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
   hideLinkOutIcon?: boolean
   id?: string
   items?: Iterable<T>
-  loadingState?: LoadingState
   onAction?: (Key, T) => void
   onClose?: () => void
-  onLoadMore?: () => any
   onSelectionChange?: (Selection) => void
   selectedKeys?: 'all' | Iterable<Key>
   selectionMode?: SelectionMode
   shouldCloseOnSelect?: boolean
   size?: 'S' | 'M' | 'L' | 'XL' = 'M'
   slot?: string | null
   styles?: StylesProp
 }

@rspbot

rspbot commented Sep 9, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (11)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/4470198850567d8384e836b9b0c60b2f860f7965/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/4470198850567d8384e836b9b0c60b2f860f7965/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants