chore: (DNM) Test branch for rework scroll utilities and fix layout bugs- #10556 - #10588
Open
LFDanLu wants to merge 2 commits into
Open
chore: (DNM) Test branch for rework scroll utilities and fix layout bugs- #10556#10588LFDanLu wants to merge 2 commits into
LFDanLu wants to merge 2 commits into
Conversation
|
Build successful! 🎉 |
## API Changes
@react-aria/utils/@react-aria/utils:getScrollParent getScrollParent {
- node: Element
+ element: Element
checkForOverflow?: boolean
returnVal: undefined
}/@react-aria/utils:getScrollParents getScrollParents {
- node: Element
+ element: Element
checkForOverflow?: boolean
returnVal: undefined
}/@react-aria/utils:isScrollable isScrollable {
- node: Element | null
- checkForOverflow?: boolean
+ node: BoundingNode
+ options?: ScrollableOptions | boolean
returnVal: undefined
}@react-spectrum/ai/@react-spectrum/ai:Attachment Attachment {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
- children: ReactNode
+ children: ReactNode | (AttachmentRenderProps) => ReactNode
density?: 'compact' | 'regular' | 'spacious' = 'regular'
download?: boolean | string
href?: Href
hrefLang?: string
isDisabled?: boolean
isInvalid?: boolean
onAction?: () => void
onPress?: (PressEvent) => void
onPressChange?: (boolean) => void
onPressEnd?: (PressEvent) => void
onPressStart?: (PressEvent) => void
onPressUp?: (PressEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, TagRenderProps>
routerOptions?: RouterOptions
size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
styles?: StyleString
target?: HTMLAttributeAnchorTarget
textValue?: string
uploadProgress?: number
value?: T
variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'
}/@react-spectrum/ai:PromptFieldValue PromptFieldValue {
Direction: any
SelectedRange: any
caretPosition: Position
constructor: (readonly Array<TokenFieldSegment<T>>, TokenFieldValueOptions) => void
delete: (Position, Intl.Segmenter, any, any) => this
deleteLine: (Position, any, any) => this
endCoalescing: () => void
findBoundaryWithSegmenter: (Position, Intl.Segmenter, any) => Position | null
findLineBoundary: (Position, any) => Position | null
findText: (Position, any, string | RegExp) => Position | null
redo: () => this
replaceRange: (Position, Position, string, any) => this
replaceRangeWithSegments: (Position, Position, Array<TokenFieldSegment>, any) => this
segments: readonly Array<TokenFieldSegment<T>>
selectedRange: SelectedRange
slice: (Position, Position) => this
- toString: () => void
+ toString: () => string
tokenize: (string) => Array<TokenFieldSegment>
undo: () => this
withCaretPosition: (Position) => this
withSelectedRange: (SelectedRange) => this/@react-spectrum/ai:PromptField PromptField {
acceptedAttachmentTypes?: Array<string>
- aiDisclaimer?: React.ReactNode
attachments?: Array<PromptFieldAttachment>
brandColor?: string
children: React.ReactNode
defaultAttachments?: Array<PromptFieldAttachment>
isGenerating?: boolean
onAITermsPress?: () => void
onAddAttachments?: (Array<PromptFieldAttachment>) => void
onAttachmentsChange?: (Array<PromptFieldAttachment>) => void
onChange?: (PromptFieldValue) => void
onRemoveAttachments?: (Array<PromptFieldAttachment>) => void
onStop?: () => void
onSubmit?: (PromptFieldValue, Array<PromptFieldAttachment>) => void
size?: 'S' | 'M' = 'M'
styles?: StyleString
value?: PromptFieldValue
variant?: 'balanced' | 'prominent' | 'subtle' = 'balanced'
}/@react-spectrum/ai:PromptToken PromptToken {
children: React.ReactNode
+ className?: ClassNameOrFunction<TokenRenderProps> = 'react-aria-Token'
+ style?: StyleOrFunction<TokenRenderProps>
token: TokenSegment<PromptFieldTokenValue>
}/@react-spectrum/ai:ExecutionTraceItem ExecutionTraceItem {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
- children: string
+ children: ReactNode
detail?: ReactNode
detailMaxHeight?: number = 120
icon?: ReactNode
id?: string
styles?: StyleString
}/@react-spectrum/ai:ResponseStatusTitle ResponseStatusTitle {
- children: string
+ children: React.ReactNode
id?: string
level?: number = 3
pixelLoader?: Array<Cell> | Array<Array<Cell>>
styles?: StyleString/@react-spectrum/ai:ThreadItem ThreadItem {
allowsArrowNavigation?: boolean
- children: ReactNode
+ children?: ChildrenOrFunction<GridListItemRenderProps>
focusMode?: 'child' | 'row'
id?: Key
isStreaming?: boolean
shouldAnnounceOnMount?: boolean
textValue?: string
}/@react-spectrum/ai:AttachmentProps AttachmentProps {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
- children: ReactNode
+ children: ReactNode | (AttachmentRenderProps) => ReactNode
density?: 'compact' | 'regular' | 'spacious' = 'regular'
download?: boolean | string
href?: Href
hrefLang?: string
isDisabled?: boolean
isInvalid?: boolean
onAction?: () => void
onPress?: (PressEvent) => void
onPressChange?: (boolean) => void
onPressEnd?: (PressEvent) => void
onPressStart?: (PressEvent) => void
onPressUp?: (PressEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, TagRenderProps>
routerOptions?: RouterOptions
size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
styles?: StyleString
target?: HTMLAttributeAnchorTarget
textValue?: string
uploadProgress?: number
value?: T
variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'
}/@react-spectrum/ai:PromptFieldProps PromptFieldProps {
acceptedAttachmentTypes?: Array<string>
- aiDisclaimer?: React.ReactNode
attachments?: Array<PromptFieldAttachment>
brandColor?: string
children: React.ReactNode
defaultAttachments?: Array<PromptFieldAttachment>
isGenerating?: boolean
onAITermsPress?: () => void
onAddAttachments?: (Array<PromptFieldAttachment>) => void
onAttachmentsChange?: (Array<PromptFieldAttachment>) => void
onChange?: (PromptFieldValue) => void
onRemoveAttachments?: (Array<PromptFieldAttachment>) => void
onStop?: () => void
onSubmit?: (PromptFieldValue, Array<PromptFieldAttachment>) => void
size?: 'S' | 'M' = 'M'
styles?: StyleString
value?: PromptFieldValue
variant?: 'balanced' | 'prominent' | 'subtle' = 'balanced'
}/@react-spectrum/ai:PromptTokenProps PromptTokenProps {
children: React.ReactNode
+ className?: ClassNameOrFunction<TokenRenderProps> = 'react-aria-Token'
+ style?: StyleOrFunction<TokenRenderProps>
token: TokenSegment<PromptFieldTokenValue>
}/@react-spectrum/ai:ExecutionTraceItemProps ExecutionTraceItemProps {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
- children: string
+ children: ReactNode
detail?: ReactNode
detailMaxHeight?: number = 120
icon?: ReactNode
id?: string
styles?: StyleString
}/@react-spectrum/ai:ResponseStatusTitleProps ResponseStatusTitleProps {
- children: string
+ children: React.ReactNode
id?: string
level?: number = 3
pixelLoader?: Array<Cell> | Array<Array<Cell>>
styles?: StyleString/@react-spectrum/ai:ThreadItemProps ThreadItemProps {
allowsArrowNavigation?: boolean
- children: ReactNode
+ children?: ChildrenOrFunction<GridListItemRenderProps>
focusMode?: 'child' | 'row'
id?: Key
isStreaming?: boolean
shouldAnnounceOnMount?: boolean
textValue?: string
}@react-spectrum/s2/@react-spectrum/s2:Menu Menu <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children: ReactNode | (T) => ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
hideLinkOutIcon?: boolean
id?: string
items?: Iterable<T>
- loadingState?: LoadingState
onAction?: (Key, T) => void
onClose?: () => void
- onLoadMore?: () => any
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
size?: 'S' | 'M' | 'L' | 'XL' = 'M'
slot?: string | null
styles?: StylesProp
}/@react-spectrum/s2:MenuProps MenuProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children: ReactNode | (T) => ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
hideLinkOutIcon?: boolean
id?: string
items?: Iterable<T>
- loadingState?: LoadingState
onAction?: (Key, T) => void
onClose?: () => void
- onLoadMore?: () => any
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
size?: 'S' | 'M' | 'L' | 'XL' = 'M'
slot?: string | null
styles?: StylesProp
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: