fix: surface async user input events - #496
Open
jbulpitt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delivery: "async"agent-message questions through ACP_meta.codex.asyncUserInputOpenAI Codex's
request_user_input_asyncreturns{"accepted":true}immediately. Its actual question arrives later as anitem/startedanditem/completedagentMessagewithdelivery:"async"andquestions; a reply is an ordinary new user message on the same thread, not a response to a pending JSON-RPC request. The current handler drops both item notifications, so ACP clients cannot render or route the question.Verification
npm run typecheckvitest run src/__tests__/CodexACPAgent/agent-message-events.test.ts --no-file-parallelism— 3/3The patch changes no blocking
item/tool/requestUserInputrequest/response behavior.Downstream context: jbulpitt/seam-acp#297