fix: surface expired auth as AuthRequired - #505
Open
kocaemre wants to merge 1 commit into
Open
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthRequiredfor terminal Codex auth failures even when a session had credentials configured.InternalErrorpath.Closes #495
Test Plan
npm test -- src/__tests__/CodexACPAgent/auth-error-events.test.ts -t 'AuthRequired|configured non-auth'npm test -- src/__tests__/CodexACPAgent/auth-error-events.test.tsnpm run typechecknpm run buildgit diff --checknpm testNote: Claude Code delegation was unavailable in this cron shell because
claude auth status --textreportsNot logged in. Run claude auth login to authenticate.; implementation and validation were performed directly with local tests.