Add Oh My Pi (omp) with built-in ACP - #572
Open
Gyarados4157 wants to merge 1 commit into
Open
Conversation
Registers the upstream Oh My Pi CLI as an ACP agent. omp 18.1.9 already speaks ACP over stdio via `omp acp` / npx `@oh-my-pi/pi-coding-agent@18.1.9 acp`, so Zed and other ACP clients can install it from the registry instead of a custom agent_servers entry. This is the current built-in path, not the older standalone omp-acp adapter. Existing open PRs agentclientprotocol#301 and agentclientprotocol#502 target stale 15.x / 17.x pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Oh My Pi (
omp) to the ACP registry so Zed and other ACP clients can install it from the registry instead of a hand-written custom agent.This is not a new adapter. Oh My Pi already ships a built-in ACP server:
which is equivalent to:
Why this PR
pi-acp(upstream Pi via a third-party adapter). It does not list Oh My Pi.omp-acp, 15.9.0) and #502 (omp, 17.3.3) are stale. This one pins the current npm release 18.1.9 and uses the upstream built-in ACP command.Distribution
omp@oh-my-pi/pi-coding-agent@18.1.9withargs: ["acp"]Once merged, hourly version updates can pick up later npm releases.
Authentication
initializeadvertises Agent Auth:{ "id": "agent", "name": "Use existing local credentials", "description": "Authenticate via the provider keys/OAuth state already configured under ~/.omp." }Verified locally against the installed
omp/18.1.9binary:This matches
AUTHENTICATION.md(Agent Auth,typedefaults toagent).Validation
passed and included
Added agent: omp v18.1.9. Icon is a 16x16 monochromecurrentColorπ mark (upstream favicon uses a gradient, which the registry rejects).After merge, Zed users can install Oh My Pi from
zed: acp registryand start an external-agent thread without editingsettings.json.