feat(diskann): add Android and iOS support with portable pread I/O - #656
Draft
iaojnh wants to merge 52 commits into
Draft
feat(diskann): add Android and iOS support with portable pread I/O#656iaojnh wants to merge 52 commits into
iaojnh wants to merge 52 commits into
Conversation
# Conflicts: # .github/workflows/04-android-build.yml # CMakeLists.txt # examples/c++/CMakeLists.txt # examples/c/diskann_example.c # src/core/algorithm/CMakeLists.txt # src/core/algorithm/diskann/diskann_file_reader.cc # src/core/algorithm/diskann/diskann_file_reader.h # src/core/algorithm/diskann/diskann_pq_trainer.cc # src/core/algorithm/diskann/diskann_searcher.cc # src/core/algorithm/diskann/diskann_searcher_entity.cc # src/core/algorithm/diskann/diskann_streamer.cc # src/core/algorithm/diskann/diskann_util.h # src/core/interface/indexes/diskann_index.cc # src/db/index/common/schema.cc # tests/db/collection_test.cc
…ction API The merge of main into this branch was textually clean but semantically broken: main renamed the public zvec::Collection API from PascalCase to snake_case, while diskann_mobile_collection_test.cc exists only on this branch, so git reported no conflict and left it calling the removed methods. Rename all 63 call sites to the current API, including delete_ (delete is a keyword), delete_by_filter and group_by_query, which are not plain case changes. Verified: compiles, links, and all 4 tests pass; clang-format clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.