add mediaconch tests for aspect ratio - #1015
Open
dericed wants to merge 1 commit into
Open
Conversation
dericed
force-pushed
the
mediaconch-tests-for-aspect-ratio
branch
from
August 28, 2026 00:22
d09d0a8 to
92e2da8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #970
This was a little tricky since mediaconch doesn't give a way to test numerator and denominator values without specifying the trace location for each container (cc @JeromeMartinez). So here I decided to convert the fractional SAR (or DAR) to a decimal and test if the stored value is within a small range around it (to forgive rounding errors).