fix(@angular/build): safeguard Karma builder stream controller against closed state - #33660
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces safeguards when calling controller.enqueue and controller.close on stream controllers in Karma builders to prevent errors if the stream is already closed or cancelled. The reviewer identified additional asynchronous paths in both application_builder.ts and progress-reporter.ts where similar safeguards are missing and should be applied to prevent potential TypeError or unhandled promise rejections.
…t closed state When running Karma tests or when stream consumers (such as Architect test harness `executeOnce`) cancel the builder output stream early, both `ProgressNotifierReporter.onRunComplete` and `karma.Server` exit callbacks can attempt to enqueue results or close the `ReadableStreamController`. Under WHATWG Streams specification rules, calling `.enqueue()` or `.close()` on a controller whose `desiredSize` is `null` (closed or cancelled) throws `TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed`. This change checks `controller.desiredSize !== null` and wraps enqueue/close calls in a try-catch block to gracefully handle closed controllers.
clydin
force-pushed
the
karma-close-check
branch
from
July 27, 2026 15:15
65c2ad4 to
f58c781
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jul 28, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Karma tests or when stream consumers (such as Architect test harness
executeOnce) cancel the builder output stream early, bothProgressNotifierReporter.onRunCompleteandkarma.Serverexit callbacks can attempt to enqueue results or close theReadableStreamController.Under WHATWG Streams specification rules, calling
.enqueue()or.close()on a controller whosedesiredSizeisnull(closed or cancelled) throwsTypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed.This change checks
controller.desiredSize !== nulland wraps enqueue/close calls in a try-catch block to gracefully handle closed controllers.