Skip to content

fix(multiple): avoid instanceof checks in aria directives - #33587

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33586/aria-events
Jul 27, 2026
Merged

fix(multiple): avoid instanceof checks in aria directives#33587
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33586/aria-events

Conversation

@crisbeto

@crisbeto crisbeto commented Jul 26, 2026

Copy link
Copy Markdown
Member

We were using instanceof HTMLElement in a few Aria directives. This excludes SVG elements and can be problematic for SSR.

Fixes #33586.

@crisbeto
fix(multiple): avoid instanceof checks in aria directives
84f0853 
We were using `instanceof HTMLElement` in a few Aria directives. This excludes SVG elements and can be problematic for SSR.

Fixes angular#33586.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 26, 2026
@pullapprove
pullapprove Bot requested review from andrewseguin and tjshiu July 26, 2026 17:12
@crisbeto
crisbeto requested a review from ok7sai July 26, 2026 17:13
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 27, 2026
@crisbeto
crisbeto merged commit e93f48e into angular:main Jul 27, 2026
31 of 33 checks passed
@crisbeto

crisbeto commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jul 27, 2026
@crisbeto
fix(multiple): avoid instanceof checks in aria directives (#33587)
ba02c5f 
We were using `instanceof HTMLElement` in a few Aria directives. This excludes SVG elements and can be problematic for SSR.

Fixes #33586.

(cherry picked from commit e93f48e)
crisbeto added a commit that referenced this pull request Jul 27, 2026
@crisbeto
fix(multiple): avoid instanceof checks in aria directives (#33587)
963383e 
We were using `instanceof HTMLElement` in a few Aria directives. This excludes SVG elements and can be problematic for SSR.

Fixes #33586.

(cherry picked from commit e93f48e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok7sai ok7sai ok7sai approved these changes
@andrewseguin andrewseguin Awaiting requested review from andrewseguin
@tjshiu tjshiu Awaiting requested review from tjshiu

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(aria): pointer events on SVG children are discarded by listbox, tabs and tree

2 participants

@crisbeto @ok7sai