Skip to content

feat(renovate-presets): pin GitHub Actions to SHA digests and ignore next tag for angular/dev-infra - #3886

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:renovate-pin-github-actions
Jul 30, 2026
Merged

feat(renovate-presets): pin GitHub Actions to SHA digests and ignore next tag for angular/dev-infra#3886
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:renovate-pin-github-actions

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

Description

Extends the helpers:pinGitHubActionDigests Renovate preset in default.json5 to automatically pin GitHub Actions to immutable commit SHAs with a trailing version comment (e.g. @<sha> # <sha> or @<sha> # <tag>).

Additionally, configures followTag: null for angular/dev-infra since action references from angular/dev-infra do not publish a next tag.

Changes

  • renovate-presets/default.json5:
    • Add 'helpers:pinGitHubActionDigests' to extends array.
    • Add package rule with followTag: null for angular/dev-infra.

@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Jul 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Renovate presets configuration by adding the 'helpers:pinGitHubActionDigests' helper and disabling 'next' tag tracking for 'angular/dev-infra'. A review comment suggests using 'matchPackageNames' with glob patterns instead of 'matchDepNames' to ensure that sub-paths and sub-actions within the 'angular/dev-infra' repository are correctly matched.

Comment thread renovate-presets/default.json5 Outdated
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2026
@alan-agius4
alan-agius4 force-pushed the renovate-pin-github-actions branch from e98e7f2 to 46fca82 Compare July 30, 2026 10:56
Comment thread renovate-presets/default.json5 Outdated
{
followTag: null,
matchDepNames: ['@angular/benchpress'],
matchDepNames: ['@angular/benchpress', 'angular/dev-infra'],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be @angular/dev-infra?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly for the github actions so it's not published. But I can add add that.

@alan-agius4
alan-agius4 force-pushed the renovate-pin-github-actions branch from 46fca82 to b010fb7 Compare July 30, 2026 14:32

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…next tag for angular/dev-infra

Extend the `helpers:pinGitHubActionDigests` Renovate preset in `default.json5` to automatically pin GitHub Actions to immutable commit SHAs with a trailing version comment (e.g. `@<sha> # <sha>` or `@<sha> # <tag>`).

Additionally, configure `followTag: null` for `angular/dev-infra` since action references from `angular/dev-infra` do not publish a `next` tag.
@alan-agius4
alan-agius4 force-pushed the renovate-pin-github-actions branch from b010fb7 to 325a257 Compare July 30, 2026 14:36
@alan-agius4
alan-agius4 merged commit 24ba970 into angular:main Jul 30, 2026
17 checks passed
@alan-agius4

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the renovate-pin-github-actions branch July 30, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants