ci: fix zizmor security analysis findings across workflows - #3888
Merged
Conversation
Suppresses safe dangerous-triggers findings, resolves template injection via environment variables in reusable-release.yml, and adds explicit permissions to rules_sass-compiler-updates.yml.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
angular-robot
Bot
added
the
area: build & ci
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Zizmor reports security analysis findings on workflow triggers (
pull_request_target), template expansions inreusable-release.yml, and missing permissions inrules_sass-compiler-updates.yml.Issue Number: N/A
What is the new behavior?
# zizmor: ignore[dangerous-triggers] - {Trigger is safe as workflow does not checkout untrusted code}to safepull_request_targetworkflows (codeql.ymlanddev-infra.yml)..github/workflows/reusable-release.ymlby using$WORKFLOW_REFenvironment variable..github/workflows/rules_sass-compiler-updates.yml.Does this PR introduce a breaking change?
Other information