feat: Add a "Loop states" section showing the label state machine on the (#84) - #85
Open
baderdean wants to merge 1 commit into
Open
feat: Add a "Loop states" section showing the label state machine on the (#84)#85baderdean wants to merge 1 commit into
baderdean wants to merge 1 commit into
Conversation
Member
Author
|
VERDICT: PASS
Diff review mode: no preview URL was available, so criteria were graded against the PR diff and a fresh build of the PR branch (head 9ae2cda). All acceptance criteria pass. ✅ Ready to merge. The PR has been assigned to you for approval. To approve and merge, reply Reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #84 — iteration 1/5
Screenshots (screenshot review mode)
📱 Mobile (390x844)
🖥️ Desktop (1440x900)
What changed
Approach
loopStatesfolder collection (one.mdper state) and aloopStatesHeadersingle-file collection, registered insrc/content.config.ts. Schema{ order, label, description, type, typeLabel }withtype ∈ autonomous|human|terminal. All copy is CMS-editable (acceptance criterion 5), mirroring the existing why/cards split.<section class="loop">between how-it-works and why-boucle inindex.astro. Desktop ≥1024px: 4-column grid, left-to-right reading order; 768–1024px: 2 columns; <768px: single column with a connector rail down the left edge (no horizontal scroll at 390px). Conforms to DESIGN §2 (tokens), §3 (no motion), §4 (components).boucle:humanis pulled out of the numbered<ol>into its own branch block beneath the sequence, with a visible join notch + "Escalation branch" tag, keeping the terminal (struck-through) treatment so it reads as an exit. Branch conveyed purely by layout, not a new colour.--accent-cyanchip, human =--accentgold chip, terminal =--text-secondarychip, nodes on--surface-raised. No new colours, no hardcoded hex/rgba in the section CSS. No animation (non-goal).aria-labelsection + ordered list, each chip carries a visibletypeLabel(colour is never the only signal), legendaria-hidden.loopStates+loopStatesHeadercollections topublic/admin/config.yml; added a Loop states component spec toDESIGN.md(Docs impact per triage).Scope Self-Check
Task as stated: add a loop-states section (collection, schema, render, CMS, responsive, no animation, no new colour) between how-it-works and why-boucle.
Files I touched: 9
src/content/loop-states/*.md,loop-states-header.md,src/content.config.ts,src/pages/index.astro,public/admin/config.yml,DESIGN.md.Lines I'm tempted to add but won't: none — no animation JS, no chip links, no README/docs additions.
Abstractions considered and rejected: a single header+state union collection (over-engineered vs the existing split); a per-node arrow/grid connector (fragile).
Diff size: ~440 insertions.
Could it be smaller? No — nine states, responsive layout, and CMS wiring are all required by the spec.
Closes #84 | 1 commit(s) | boucle worker run 1/5 | mode: deploy=self review=preview