Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/permission.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ const layer = Layer.effect(
action: input.action,
resources: input.resources,
save: input.save,
metadata: input.metadata,
metadata: input.metadata
? Object.fromEntries(Object.entries(input.metadata).filter(([, value]) => value !== undefined))
: undefined,
source: input.source,
}
}
Expand Down
27 changes: 27 additions & 0 deletions packages/core/test/permission.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,33 @@ describe("PermissionV2", () => {
}),
)

it.effect("omits undefined permission metadata fields", () =>
Effect.gen(function* () {
yield* setup()
const service = yield* PermissionV2.Service
yield* service.ask(
assertion({
metadata: {
root: ".",
path: undefined,
limit: undefined,
enabled: false,
count: 0,
nullable: null,
},
}),
)

const request = yield* service.get(PermissionV2.ID.create("per_test"))
expect(request?.metadata).toEqual({
root: ".",
enabled: false,
count: 0,
nullable: null,
})
}),
)

it.effect("evaluates against an explicit provider-turn agent", () =>
Effect.gen(function* () {
yield* setup([{ action: "read", resource: "*", effect: "allow" }])
Expand Down
Loading